Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libdjinterop to 0.21.0 #13231

Closed
daschuer opened this issue May 13, 2024 · 5 comments
Closed

Update libdjinterop to 0.21.0 #13231

daschuer opened this issue May 13, 2024 · 5 comments
Labels
Milestone

Comments

@daschuer
Copy link
Member

Bug Description

Unfortunately the nighly builds on Launchpad are currently failing because of the recent libdjinterop update.
This broke the link to https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+sourcefiles/libdjinterop/0.20.2-0ubuntu1/libdjinterop_0.20.2.orig.tar.gz

Maybe we need to move libdjinterop to our PPA to have always the referenced version available.

Luckily our 2.4.1 build is not affected because it was build before the update.

@mr-smidge
Do you have a good idea what is the best way to solve this issue?

Version

main

OS

Ubuntu

@daschuer daschuer added the bug label May 13, 2024
@daschuer daschuer added this to the 2.5-beta milestone May 13, 2024
@mr-smidge
Copy link
Contributor

Hi @daschuer - I was not aware that Launchpad automatically removes old versions of packages from PPAs, apologies.

I'm not aware of any other users of the PPA, so I'll remove the latest version and downgrade to 0.20.2 to hopefully fix the immediate issue.

Longer-term, I'm not immediately sure what the most appropriate fix is... but happy to contribute to the discussion.

@mr-smidge
Copy link
Contributor

Ugh, actually it looks like re-uploading old versions will not work.

The differences between 0.20.2 and 0.21.0 are all non-breaking, so an upgrade might be the simplest fix for the immediate issue: #13233

@daschuer
Copy link
Member Author

What do you think about the idea to copy the libdjinteropt in the required version to the mixxx PPA?

Package maintainer might be tempted to link it as a package, which brings the stable API question back to the table.
How has the situation developed since our last discussion?

@mr-smidge
Copy link
Contributor

In the meantime, I will not upload any new versions to the PPA unless I am also updating Mixxx at the same time.

Longer term, the suggestion of moving libdjinterop into the Mixxx PPA might be best (until such time as the library has a stable interface). I wonder if the same package can be simultaneously uploaded to multiple PPAs? 🤔

@mr-smidge
Copy link
Contributor

which brings the stable API question back to the table. How has the situation developed since our last discussion?

There are definitely some more breaking changes I can think of making before reaching a 1.0 stable API. I'm ok with this idea when ready, but I think to try and do this now would be cementing in an API that still has quite a few rough edges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants