Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Del key in sidebar doesn't trigger crate/playlist delete dialog anymore #13361

Open
ronso0 opened this issue Jun 11, 2024 · 1 comment · May be fixed by #13364
Open

Del key in sidebar doesn't trigger crate/playlist delete dialog anymore #13361

ronso0 opened this issue Jun 11, 2024 · 1 comment · May be fixed by #13364
Labels
Milestone

Comments

@ronso0
Copy link
Member

ronso0 commented Jun 11, 2024

Bug Description

Due to
https://github.com/mixxxdj/mixxx/blame/abd9d11bf7ee09d259e568590a3f669547b53374/src/widget/wlibrarysidebar.cpp#L246-L248
the Delete code can't be reached anymore.

Probably a leftover from #12020
And i think we overlooked -or I forgot it- that this does clear the AutoDJ queue without confirmation!
(which I consider a blocker btw. Unlikely it happens, but if it does you might screw your carefully curated AutoDJ playlist)

Removing this branch (and related methods like clear()) fixes the original issue.
But what about clearing AutoDJ queue from the sidebar?

  1. rename AutoDJFeature::clear() -> AutoDJFeature::deleteItem and add a confirmation dialog?
  2. add a respective sidebar menu action to make the feature discoverable?
  3. remove it?

I'd vote for 1. + 2. Though, if we'd be strict with the string freeze we'd need to drop it and reintroduce it in 2.6 with the proper dialog and sidebar menu action.

Additionally, we may allow deleteItem for the AutoDJ crates.

Version

2.5-alpha

OS

No response

@ronso0 ronso0 added the bug label Jun 11, 2024
@ronso0 ronso0 changed the title Del key doesn't trigger crate/playlist delete dialog anymore Del key in sidebar doesn't trigger crate/playlist delete dialog anymore Jun 11, 2024
@ronso0 ronso0 added this to the 2.5.0 milestone Jun 11, 2024
@daschuer
Copy link
Member

I think we can be less strict with string freeze because we have always anyway many untranslated strings.
So one more to make an important bug-fixvis OK for me
We should be strict, not to change the source strings of already translated strings during a beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants