'sort by bpm' in library doesn't

[mixxxbot]

Reported by: dan-telent
Date: 2008-02-18T02:27:18Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp192809
Attachments: screenshot

---

In the Ubuntu binary packages of 1.6.0beta2, clicking on the 'BPM' column title seems to be sorting the tracks alphabetically not numerically. Or if that's not what it's doing, it's doing something non-obvious

95.3, 84.5, 82.7, 82.7, 79.3, 71.7, 312.2, 129.6, 127.2

I'll see if I can attach a screenshot

[mixxxbot]

Commented by: dan-telent
Date: 2008-02-18T02:29:10Z
Attachments: screenshot

---

312.2 is a typo for 132.2, if you didn't guess

[mixxxbot]

Commented by: asantoni
Date: 2008-02-19T14:19:33Z

---

Thanks for the bug report Dan. I looked at trying to fix this a few weeks ago, and I thought it'd be a slam-dunk, but I couldn't find the place where the logic was incorrect. It looks like it might be lexicographically comparing the BPMs as strings as opposed to just comparing the floats...

Thanks,
Albert

[mixxxbot]

Commented by: deftdawg
Date: 2008-03-01T20:36:46Z

---

fix is in proxymodel.cpp - svn revision 1862

sort now behaves as follows (where 0.0 is no valid BPM detection data):
89.9, 123.0, 127.4, 0.0
127.4, 123.0, 89.9, 0.0

[mixxxbot]

Issue closed with status Fix Released.