Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to allow the 'optimize' build parameter to be used to patch arbitrary CXXFLAGS #4934

Closed
mixxxbot opened this issue Aug 22, 2022 · 4 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: awilliamson
Date: 2008-03-09T17:11:03Z
Status: Won't Fix
Importance: Low
Launchpad Issue: lp200253
Attachments: [Patch to allow arbitrary optflags](https://bugs.launchpad.net/bugs/200253/+attachment/225726/+files/Patch to allow arbitrary optflags)


This patch allows the 'optimize' parameter to be a string as well as an integer. If it's a string, the string will be passed on as CXXFLAGS. This is useful for distributions which have standard build parameters that are required to be used for all packages (I wrote the patch for the Mandriva package).

You might want to take a different approach to this - add a new parameter, for instance - but the essence of the patch would be a good thing to have.

I also noticed while writing this patch that passing optimize=0 is not optimally handled in the Linux case. It will print "Optimizations enabled..." (as 0 is an integer) but not actually enable any optimizations. I did not address this in my patch, but it's something you might want to fix.

@mixxxbot
Copy link
Collaborator Author

Commented by: awilliamson
Date: 2008-03-09T17:11:03Z
Attachments: [Patch to allow arbitrary optflags](https://bugs.launchpad.net/mixxx/+bug/200253/+attachment/225726/+files/Patch to allow arbitrary optflags)

@mixxxbot
Copy link
Collaborator Author

Commented by: asantoni
Date: 2008-03-09T17:13:35Z


Will push this into trunk later, patch looks good and should be handy for package maintainers. Thanks for the patch!

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-10-16T19:59:31Z


The build system has changed a lot since this was done.. closing as WontFix

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Won't Fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant