New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack smash on OS X in AnalyserBPM #5091

Closed

mixxxbot opened this issue Aug 22, 2022 · 6 comments

Collaborator

mixxxbot commented Aug 22, 2022

Reported by: kousu
Date: 2009-02-04T19:15:24Z
Status: Fix Released
Importance: Undecided
Launchpad Issue: lp325437
Attachments: [This is the first file that was crashing before my fix](https://bugs.launchpad.net/bugs/325437/+attachment/454524/+files/This is the first file that was crashing before my fix), [This is a file that still crashes after my fix](https://bugs.launchpad.net/bugs/325437/+attachment/454526/+files/This is a file that still crashes after my fix)

AnalyserBPM::process has a hardcoded buffer for samples to pass into soundtouch. The size of this buffer was increased to make BPM detection better, but this has started causing crashes on OS X (because it is overflowing the stack).

I moved the buffer into the class instead of the method and that seemed to fix it but I've found files that it will crash on after starting to play the track for a few seconds.

Posting this so we record test cases to make sure we don't break this again in the future.

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: kousu
Date: 2009-02-04T19:15:24Z
Attachments: [This is the first file that was crashing before my fix](https://bugs.launchpad.net/mixxx/+bug/325437/+attachment/454524/+files/This is the first file that was crashing before my fix)

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: kousu
Date: 2009-02-04T19:17:39Z
Attachments: [This is a file that still crashes after my fix](https://bugs.launchpad.net/mixxx/+bug/325437/+attachment/454526/+files/This is a file that still crashes after my fix)

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: rryan
Date: 2009-03-29T03:51:26Z

We need to remember to check this again once we merge in the fix for the SoundTouch buffer overflow.

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: rryan
Date: 2009-03-29T03:51:55Z

Self assign, and confirm since I believe I can reproduce it.

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: rryan
Date: 2009-04-05T17:36:45Z

We don't use this buffer anymore, and furthermore the files do not crash anymore for me. Marking fixed in 1.7.0.

Collaborator Author

mixxxbot commented Aug 22, 2022

Issue closed with status Fix Released.

mixxxbot closed this as completed

mixxxbot transferred this issue from another repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment