Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External audio pass through #5126

Closed
mixxxbot opened this issue Aug 22, 2022 · 12 comments
Closed

External audio pass through #5126

mixxxbot opened this issue Aug 22, 2022 · 12 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Pegasus-RPG
Date: 2009-04-06T00:36:15Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp355945
Tags: mic, microphone, pass, passthrough, radio, talkover, through, vinylcontrol


It would be nice, for those of us using vinyl control, to be able to click a radio button on the GUI that disables the waveform and just connects the aux input for vinyl control on that deck to the channel output (so it passes through the cross-fader & fx (if possible,) etc.) That way we can very easily mix external media into our sets, especially when using a MIDI mixer controller instead of a hardware mixer.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2009-07-10T04:16:49Z


This is a common enough request that I think we should probably implement it -- possibly a 1.8 side project.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2010-09-20T21:35:49Z


Albert's suggestion was to target this for 1.10, which is also when my features_vinyl stuff is supposed to go in. This would help make 1.10 The Big Vinyl Release :)

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-05-04T04:46:22Z


Fixed in r3357

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-05-04T07:23:09Z


Sounds interesting, but any notes on how to use it? Any new controls in the UI or preferences settings needed?

On Saturday, May 4, 2013 at 6:46 AM, Owen Williams wrote:

Fixed in r3357

** Changed in: mixxx
Milestone: None => 1.12.0

** Changed in: mixxx
Status: Confirmed => Fix Committed

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/355945

Title:
External audio pass through

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/355945/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-05-04T15:38:33Z


There is a new controlobject called ChannelX,passthrough_enabled which toggles the passthrough state. It is default off so there are no preferences needed, but there will need to be some sort of UI required. In my own version I had the vinyl status widget turn blue when passthrough was on, but this patch just enables the behavior. (We should probably open a separate bug to complete the UI for it)

@mixxxbot
Copy link
Collaborator Author

Commented by: guy-m
Date: 2013-08-29T17:06:44Z


Built 'master' a couple of hours ago. All seems to work.

Could I please get a quick pointer, I would like to update the Hercules RMX script I'm using to enable it for this feature please?
Even just the commit on GIT for another script that's been updated would be enough I hope.

Not sure where to request this (tried IRC).

Great app!

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-08-29T17:45:22Z


I just sent this note to someone else, so I'll paste it here:

Right now the passthrough mode isn't revealed in the user interface, but it's possible to assign that function to a key or midi button. For instance to add a keyboard shortcut, you'd make sure your keyboard config file (as described here: http://mixxx.org/manual/latest/chapters/advanced_topics.html#making-a-custom-keyboard-mapping) has:

[Channel1]
passthrough_enabled Ctrl+g

[Channel2]
passthrough_enabled Ctrl+h

or whatever keys you want to use.

I think that function is learnable in the midi control wizard if you
want to assign passthrough to a midi button.

@mixxxbot
Copy link
Collaborator Author

Commented by: guy-m
Date: 2013-08-29T19:15:12Z


When using either a customer midi binding or the keyboard mapping, I get a similar error:

Debug [Controller]: "MIDI status 0xB0 (ch 1, opcode 0xB), ctrl 0x13, val 0x00" 
Debug [Controller]: Not a function 

Warning [Main]: ControlObject::getControl returning NULL for ( "[Channel1]" , "passthrough_enabled" ) 
Debug [Main]: Warning: Keyboard key is configured for nonexistent control:  "[Channel1]"   "passthrough_enabled" 

Is there a way to double check that the EnginePassthrough is loading properly?

Thought these were the names for the configurations::
m_pEnabled(new ControlObject(ConfigKey(pGroup, "passthrough_enabled"))),
m_pPassing(new ControlPushButton(ConfigKey(pGroup, "passthrough"))),

Sorry to be a bother.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-09-01T13:49:37Z


I'm going to open a new bug for this issue.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-09-01T13:50:42Z


New bug is: https://bugs.launchpad.net/mixxx/+bug/1219456

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-10-06T11:31:47Z


In latest https://github.com/mixxxdj/mixxx/tree/master It works using "passthrough", not "passthrough_enabled", e.g.

[Channel1]
passthrough Ctrl+g

[Channel2]
passthrough Ctrl+h

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant