-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oops, forgot to bundle MSVC DLLs #5173
Comments
Commented by: Pegasus-RPG Have her first try http://www.mixxx.org/packages/windows/Mixxx-1.7.0~beta1-Qt4.5.0-win32.exe If that doesn't work, have her install http://www.microsoft.com/downloads/info.aspx?na=22&p=4&SrcDisplayLang=en&SrcCategoryId=&SrcFamilyId=&u=%2fdownloads%2fdetails.aspx%3fFamilyID%3deb4ebe2d-33c0-4a47-9dd4-b9a6d7bd44da%26DisplayLang%3den |
Commented by: Pegasus-RPG The results of trying those will help in determining where exactly the problem lies. Also, if she could grab any relevant events from the Application and System logs in the Event Viewer, that too would help. http://www.mixxx.org/wiki/doku.php/reporting_bugs#gathering_logs |
Commented by: nicolasdiogo hi, i was trying to install the mixxx x64 on a vista ultimate x64 (amd64) and got the same error message, here is the application log
|
Commented by: asantoni Uhhh, Sean, are we distributing the 64-bit version of the Microsoft The ones we distribute with our 32-bit builds are 32-bit. Also, if you On Wed, May 20, 2009 at 2:33 AM, Nicolas Diogo wrote:
|
Commented by: nicolasdiogo hello again, i believe my problem was related to .Net framework update that did not work properly. i rollback the .Net update and run the package again and it is all fine now. thanks for the prompt response, and apologies for the false alarm. Nicolas |
Commented by: Pegasus-RPG We aren't distributing them at all to my knowledge. Some users may need to install them as explained in the last bullet here: http://mixxx.org/wiki/doku.php/compiling_on_windows#current_issues_fixes_todo But Nicolas' find is interesting. I'll have to wreck my build environment to try to replicate the problem though. |
Commented by: asantoni No no, we should be distributing the Visual Studio runtime DLLs. We Adam, do you remember what's going on with the runtime DLLs? On Fri, May 22, 2009 at 12:40 PM, Pegasus wrote:
|
Commented by: Pegasus-RPG Ah so...opening the win32 build you made as a 7-Zip file indeed shows msvcm80, p80, and r80 dlls while my x64 build has none of those. They are commented out in the NSI file too, so I thought they were old or something. Do I need libflac and cmetrics too? (FLAC files work find in the x64 build for me as-is.) What's dbghelp.dll? |
Commented by: Pegasus-RPG r2444 of the 1.7 branch now contains a much more intelligent makerelease process which requires the presence of the msvc*.dll files. See http://mixxx.org/wiki/doku.php/build_windows_installer for full details. |
Commented by: asantoni Ahhh very nice, thank you! On Tue, Jul 7, 2009 at 5:58 PM, Pegasus wrote:
|
Commented by: Pegasus-RPG I'm still getting this error testing on Win32. The DLLs are in place. I'm afraid we'll have to include the MSM from the redistribution installer and get NSIS to install it as part of the Mixxx installation, so the DLLs end up in the SideBySide cache. I'm going to need help on this. Otherwise, we just package the entire vc redist and call its installer (wasting space on the users' HD.) |
Commented by: Pegasus-RPG
|
Commented by: Pegasus-RPG For reference: http://msdn.microsoft.com/en-us/library/ms235342(VS.80).aspx |
Commented by: asantoni http://doc.trolltech.com/4.5/deployment-windows.html#visual-studio-2005-onwards What are the other DLLs that needed bundling? I thought we came to the conclusion that we could just totally ignore On Sun, Jul 26, 2009 at 10:16 PM, Pegasus wrote:
|
Commented by: deftdawg You gents asked me to take it out of the rewritten NSIS installer script on Mar 11...
|
Commented by: Pegasus-RPG Or I can just rebuild ALL of the dependencies myself so we have control over the dependent DLLs. |
Commented by: asantoni On Mon, Jul 27, 2009 at 1:50 PM, Pegasus wrote:
Sorry, why would that solve the problem? Re: what Garth said, yeah, I thought we could just delete the |
Commented by: Pegasus-RPG
Because we're having problems with DLLs that the pre-built Mixxx dependencies depend on, evidenced by the fact that their versions are VS 2005, and I'm using VS 2008.
I didn't understand why it helped before, but I have a good idea now, having read the first article I linked to above (look toward the bottom of the article.) Last time, we were carrying around a manifest for an old/wrong version of a DLL, so removing it helped, at least on systems that had the correct version installed (or we just didn't need that DLL at all anymore.) This time, at least right now, according to the mixxx.exe.manifest, for win32, we need a particular version of msvcrt80.dll. Win64 wants a debug and runtime build of that same version of that same DLL as well as msvcrt90.dll. So we have a few choices: 1) for each of the x86 and x64 version of Mixxx, read the mixxx.exe.manifest files and make sure to include the listed versions of the DLLs (and their manifest files, so Windows will try them first) in the Mixxx install packages, 2) don't use any pre-built dependencies but build them ourselves, making sure to specify to embed the manifest in the DLL (we may still need to include msvcrt90.dll however,) or 3) Forget all this crap and move to a MinGW build process in earnest. |
Commented by: Pegasus-RPG For now, I'm doing option #1. I sent Albert new packages that contain the relevant MSVC DLLs and manifests. Tests good on an x86 XP system. I have no clean x64 system to test on so I bundled all of the MSVC files for each requested version to be safe. Marking Fixed for 1.7. |
Commented by: asantoni Grabbing your packages from your site now. I'm going to throw them on Thanks, On Tue, Jul 28, 2009 at 8:29 AM, Pegasus wrote:
|
Commented by: nicolasdiogo Hi Albert, i also would like to ask you to post links on this list as well. thanks, Nicolas
Grabbing your packages from your site now. I'm going to throw them on Thanks, On Tue, Jul 28, 2009 at 8:29 AM, Pegasus wrote:
-- |
Commented by: Pegasus-RPG Nicolas: Have you not checked out the forums? http://mixxx.org/forums/viewtopic.php?f=1&t=731 |
Issue closed with status Invalid. |
Reported by: asantoni
Date: 2009-05-15T06:16:36Z
Status: Invalid
Importance: Critical
Launchpad Issue: lp376801
Quoting Sarah from a blog comment:
"Hey just downloaded [the Win64 build of Mixxx] and tried to install on my 64 bit vista machine. It tells me that the "side-by-side configuration is incorrect" when I try to run it, although the normal version of mixxx works fine."
Doing some googling yields:
http://channel9.msdn.com/forums/TechOff/22266-Side-by-side-screwup/
(and some other random articles about DLL versions being wrong, etc etc etc.)
Read that carefully. I think we might have accidentally bundled a .manifest file that we weren't supposed to. Can anyone confirm that this is or isn't the case?
Thanks,
Albert
The text was updated successfully, but these errors were encountered: