Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks not saved unless unloaded #5290

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

Tracks not saved unless unloaded #5290

mixxxbot opened this issue Aug 22, 2022 · 6 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Pegasus-RPG
Date: 2010-01-26T21:27:34Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp512974


On trunk r2277, a new track's analysis results (BPM and overview waveform) are not saved unless another track is loaded into that deck.

Steps to repeat:

  1. Start Mixxx, load a never-been-analyzed track
  2. Wait for analysis to finish (overview appears)
  3. Close Mixxx
  4. Open Mixxx again, load the same track, note that it has to re-analyze
  5. Load another track into the same deck.
  6. Close Mixxx
  7. Open Mixxx, load the original track and note that the overview comes up immediately.
@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: asantoni
Date: 2010-01-26T22:17:57Z


We only save track metadata back to the DB when a track is unloaded
from a player, so that's why this bug occurs.

On Tue, Jan 26, 2010 at 1:27 PM, Pegasus wrote:

Public bug reported:

On trunk r2277, when a new track's analysis results (BPM and overview
waveform) are not saved unless another track is loaded into that deck.

Steps to repeat:

  1. Start Mixxx, load a never-been-analyzed track
  2. Wait for analysis to finish (overview appears)
  3. Close Mixxx
  4. Open Mixxx again, load the same track, note that it has to re-analyze
  5. Load another track into the same deck.
  6. Close Mixxx
  7. Open Mixxx, load the original track and note that the overview comes up immediately.

** Affects: mixxx
    Importance: High
        Status: New

** Changed in: mixxx
  Importance: Undecided => High

** Changed in: mixxx
   Milestone: None => 1.8.0

--
Overview waveform (analysis) not saved to DB right away
https://bugs.launchpad.net/bugs/512974
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-01-27T09:01:50Z


Not high priority...

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-02-18T19:53:31Z


This is provoked by the fact that we don't save data on shutdown, only on track unload. This isn't a problem in the sqlite branch anymore given that I save on shutdown as well. Saving immediately to the DB isn't really an option because of the xrun issue.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-02-21T11:02:19Z


I'm hijacking this bug -- the waveform would be saved if the track was saved on shutdown -- but in trunk tracks are only saved when they are unloaded. I'm working on fixing this in features_sqlite.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-06-02T10:44:34Z


The fix is merged to trunk now, closing.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.8.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant