Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A running AnalyserQueue blocks GUI exit #5463

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

A running AnalyserQueue blocks GUI exit #5463

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: bkgood
Date: 2010-07-26T02:50:14Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp609927


If you load a song that hasn't yet been analyzed (or start the analyzer on it manually through the library) and then exit (File -> Exit, not the WM close button), the GUI just hangs there (with the File menu highlighted) until the analyzer finishes.

Not really an end-of-the-world thing, just a nicety. I guess the preferred solution is to show a modal saying something to the effect of "Please wait for a moment while I'm analyzing your song, or click this button to abort and quit immediately" but it would probably be just as user-friendly to just hide the GUI window while the analyzer finishes. Right now it just freezes, which isn't very pretty.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2010-07-26T06:34:54Z


My vote is for the modal box. (This avoids the appearance of the Mixxx process hanging.)

@mixxxbot
Copy link
Collaborator Author

Commented by: bkgood
Date: 2010-12-29T23:34:13Z


Fixed at lp:mixxx/1.9 r2639

I ended up just hiding the window, opening a dialog of some sort was turning into a total pain (can't create a dialog in a hung GUI...). Only solution would be to move destruction of MixxxApp to a different thread and that's a can of worms I'm not willing to open at the moment over a relatively rare/minor bug.

@mixxxbot
Copy link
Collaborator Author

Commented by: bkgood
Date: 2010-12-29T23:37:41Z


Fixed in lp:mixxx/1.8 r2698

@mixxxbot
Copy link
Collaborator Author

Commented by: bkgood
Date: 2011-01-02T00:47:40Z


I'm marking this wontfix -- which is utterly stupid, because I committed the fix first to 1.8 before merging to 1.9, but that was also before I knew we weren't releasing anything more from 1.8 and I don't want this to sit as "fix committed" in the 1.8 series for perpetuity.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant