Looping should try to prevent clicks

[mixxxbot]

Reported by: asantoni
Date: 2010-10-03T04:36:43Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp653896
Tags: engine, looping
Attachments: zerocross-ish-looping.diff

---

When looping, Mixxx should try to prevent clicking sounds caused by large, discontinuous jumps in the audio signal. The conventional way of doing this for mono streams is to adjust the loop start and end points to both coincide with zero crossings. This approach isn't so straightforward for stereo streams because zero crossings may not appear in both channels at the same time.

Nevertheless, I've written some code that attempts to find a compromise between the zero crossing positions in both the left and right channels, and I think it reduces clicking in most cases. Attached is the patch.

Probably a better way to do this is just to fade the audio over X samples.

[mixxxbot]

Commented by: asantoni
Date: 2010-10-03T04:36:43Z
Attachments: zerocross-ish-looping.diff

[mixxxbot]

Commented by: ywwg
Date: 2012-06-06T16:09:15Z

---

My patch in https://bugs.launchpad.net/bugs/703585 solves this a different way, but crossfading between the out point and the in point over a period of one iBufferSize.

[mixxxbot]

Commented by: rryan
Date: 2012-09-06T19:11:50Z

---

Fixed by Owen's patch in Bug #⁠703585.

[mixxxbot]

Issue closed with status Fix Released.