Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tracks (e.g. deleted, moved) are not marked missing. #5649

Open
mixxxbot opened this issue Aug 22, 2022 · 8 comments
Open

Missing tracks (e.g. deleted, moved) are not marked missing. #5649

mixxxbot opened this issue Aug 22, 2022 · 8 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: hippako
Date: 2010-11-09T21:55:57Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp673237
Tags: library, scanner


If I load the song from external hard drive and then turn out the drive, the song is still in library.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2011-10-05T01:48:37Z


This is because we stopped scanning the library on bootup. The library needs some work in the area of multiple library folders and removable libraries (ipods, external drives, etc.) so this area needs work.

@mixxxbot
Copy link
Collaborator Author

Commented by: MelGrubb
Date: 2011-11-18T17:14:12Z


I'm seeing this even with the internal drive. If I move or rename files, they never show up in the "Missing" list. I just get errors when I try to load and play them

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2011-11-18T19:34:22Z


I had considered to move missing tracks directly to the missing tracks list, if you try to load it. But I have thought that it is not a good idea to let a song disapear when the user whants to do something with it.

We need a good solution especially for crates and playlists. There is no reason to partly destroy a playlist only because a track is temporary unreachable.

What could be the best behavior?

  • Just leave the missing tracks where it is?
  • Mark the song as missing at original place "grayed out"
  • To let the user decide "Track is missing. Do you wish to move it to missing Tracks folder ..."

See also Bug #⁠239883 and Bug #⁠801700

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2011-11-18T19:46:55Z


Daniel -- I agree.

What if we had a status column that had icons in it to indicate things like:

  • track is missing
  • track has been analyzed
  • other things? failed to parse? track is low quality?

Also, missing tracks don't get remove from the crates/playlists -- they
just aren't shown. If the track is marked not-missing at some point then it
will re-appear where it was. I agree the user might go looking for a track
and be confused that it isn't in the playlist where they left it, so I
think you're right that we should fix that.

RJ

2011/11/18 Daniel Schürmann <email address hidden>

I had considered to move missing tracks directly to the missing tracks
list, if you try to load it. But I have thought that it is not a good
idea to let a song disapear when the user whants to do something with
it.

We need a good solution especially for crates and playlists. There is no
reason to partly destroy a playlist only because a track is temporary
unreachable.

What could be the best behavior?

  • Just leave the missing tracks where it is?
  • Mark the song as missing at original place "grayed out"
  • To let the user decide "Track is missing. Do you wish to move it to
    missing Tracks folder ..."

See also Bug #⁠239883 and Bug #⁠801700

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/673237

Title:
Missing songs (e.g. deleted, moved) are not marked missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/673237/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-01-19T08:08:49Z


Update:

  • Missing Tracks are not removed from Playlists.
  • Tracks are only marked as missing by the library scanner

TODO:

  • We should update the missing state at various track operations. Like adding to a playlist, loading to a deck.
  • The "Add Random" button should check the path and should not add missing tracks.
  • Adding a Missing track to a playlist/crate should be still possible (the user may collect missing tracks for some reasons)
  • We should avoid adding missing tracks to Auto DJ. This has party stopper potential.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-01-19T08:11:41Z


I have move the prio up because since "Auto DJ crates" this is more important.

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2015-02-07T22:40:31Z


I'm not sure but touching every file to check it is missing when we add a list of files to a specific crate. That sounds like we would hit a huge performance hit when all we want to do is a simple sql query.

As for AutoDj. It should handle the missing tracks gracefully. We can never relly on track in the autoDj playlist being still available (that can change between the time it was added and when it is supposed to be played).

@mixxxbot
Copy link
Collaborator Author

Commented by: ron-granger
Date: 2020-07-07T15:41:40Z


For the use case of removable devices it might be worth scanning the track folders for availability and not each single track ...

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant