New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDI presets get applied even if nothing is changed #5688

Closed

mixxxbot opened this issue Aug 22, 2022 · 4 comments

Labels

bug

Milestone

Collaborator

mixxxbot commented Aug 22, 2022

Reported by: Pegasus-RPG
Date: 2010-12-01T13:18:19Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp683634
Attachments: midi-dirty.patch

When you click OK in the preferences window, MIDI presets get re-applied (and scripts re-initialize) every time you click OK, regardless of if they've changed or not. This shouldn't happen.

mixxxbot added the bug label

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: raskolnikov
Date: 2010-12-01T13:19:48Z
Attachments: midi-dirty.patch

Fixed :-D Patch submitted.

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: Pegasus-RPG
Date: 2010-12-01T13:28:19Z

Whoops, won't fix this in 1.8, as it has other similar issues in the prefs that are already fixed in trunk.

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: Pegasus-RPG
Date: 2010-12-01T14:29:41Z

Fixed in trunk r2601. Thanks, Raskolnikov!

Collaborator Author

mixxxbot commented Aug 22, 2022

Issue closed with status Fix Released.

mixxxbot closed this as completed

mixxxbot transferred this issue from another repository

mixxxbot added this to the 1.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment