-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different playback modes for samplers #5883
Comments
Commented by: rryan need to make the call on whether this will go in 1.10 or not. we shouldn't release samplers to the world half-baked but at the same time this shouldn't blcok the release |
Commented by: rryan I think we should nail down the sampler use case in 1.11 |
Commented by: rryan For now it's kind of the "minimum viable feature". |
Commented by: rryan AFAIK not happening in 1.11 |
Commented by: marco-a-simao I dont think this is the correct description of the bug. AFAIK at 1.10 there is only one play mode: sample plays from start to end, pressing play again doesnt replay it. Am i missing something? |
Commented by: r0w4nj I've fixed this bug and implemented each of the modes... How do you think the mode switching should be done on the GUI?
As for now Ive added a button using the 4 hot cue number button .pngs to toggle between modes... I will link my brach shortly. |
Commented by: marco-a-simao We could have a single button that updates its png like: 1, 2, 3, 4 corresponding its modes, what do you think? |
Commented by: r0w4nj Do you mean a play button that changes its png or separate button? |
Commented by: marco-a-simao
|
Commented by: r0w4nj here's my branch: lp:~r0w4nj/mixxx/rowanstrunk The 4 modes I have implemented are:
There is already a dedicated repeat button so no need for a repeat play mode as per bug desc. I have only the first sampler changed the Deere 1280x1024 .xml to support this as of yet to see what people think about how to design the gui. |
Commented by: r0w4nj Cool, yeah I've implemented a seperate button you should check out my branch and see what you think :) |
Commented by: marco-a-simao
|
Commented by: marco-a-simao
|
Commented by: r0w4nj Definitely, I'd really like to work on effects integration. I haven't worked with lv2 before but it looks great :) This depends on the result of my GSOC application though as if I'm accepted I will be spending the summer implementing a loop recorder! |
Commented by: esbrandt Nice one Rowen.
Good work so far, thanks |
Commented by: r0w4nj Thanks for the feedback Jus :)
|
Commented by: r0w4nj I've now completed the following and updated my branch:
I had to create another push button within EngineBuffer for the MIDI control as mapping directly to the play button caused toggling issues. I've tested this with an MPK-mini (momentary mode: pad press = 1 pad release = 0) and everything seems ok :) |
Commented by: ywwg There seem to be a lot of changes in your branch that aren't related directly to this bug -- can you create a patch that would apply cleanly to trunk that just has the bugfix? |
Commented by: r0w4nj Here's a patch for the trunk. |
Commented by: Be-ing Considering the last activity on this was in 2013, I'm changing this from In Progress to Confirmed. |
Reported by: esbrandt
Date: 2011-05-01T11:18:43Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp774808
Tags: looping, sampler
Attachments: playmodes.patch, playmodes.patch
The text was updated successfully, but these errors were encountered: