Make the preferences dialog more accessible by associating interactive controls with controls labelling them

[mixxxbot]

Reported by: peter-v
Date: 2011-05-01T14:54:57Z
Status: Fix Released
Importance: Undecided
Launchpad Issue: lp774921
Tags: accessibility, gui
Attachments: [Patch which adds buddy property for the controls labelling interactive controls](https://bugs.launchpad.net/bugs/774921/+attachment/2103148/+files/Patch which adds buddy property for the controls labelling interactive controls)

---

The preferences dialog along with some other Mixxx dialogs is built using standard QT4 widgets such as comboboxes, radio buttons, edit fields, sliders etc... and label controls.
Label controls are usually placed next to their interactive counterparts and they are usually describing what's the interactive control used for. E.G. in the "Sound Hardware" page there is a combobox listing all the sound interfaces Mixxx supports and a label saying "Sound API".
When a sighted person looks at this page he can immediatelly recognize these two controls belong to each other.
For visually disabled or blind people it's essential to provide a markup which will enable assistive tools to provide info about this relationship.
I see this as verry important because QT4 accessibility has bugs which prevent retrieving control relationships manually what means in extreme cases the focus event is the only way on how to get an access to certain ui controls.

[mixxxbot]

Commented by: peter-v
Date: 2011-05-01T14:54:57Z
Attachments: [Patch which adds buddy property for the controls labelling interactive controls](https://bugs.launchpad.net/mixxx/+bug/774921/+attachment/2103148/+files/Patch which adds buddy property for the controls labelling interactive controls)

[mixxxbot]

Commented by: rryan
Date: 2011-10-05T03:32:10Z

---

Committed to lp:mixxx so it will be part of 1.10.0.

How should I credit your name in the contributors list? Is "Peter Vágner" alright?

Thanks again,
RJ Ryan

[mixxxbot]

Commented by: peter-v
Date: 2011-10-05T10:32:49Z

---

Hello,
Yep that name is correct.
I have noticed one more verry minor thing.
In the mixxx option dialog there are some multi line edit fields e.g. 
the one where you can enter description on the broadcasting prefereces page.
These multi line edit fields do also accept tab character.
This breaks tab key navigation.
I have added this property into the .ui files where these fields are 
defined.
Sorry I am unable to make a patch against current revision right now....
<property name="tabChangesFocus" >
<bool>true</bool>
</property>
Another instance of multiline edit field is in the track info dialog.

Can you add this as well please?

Thanks and greetings

Peter

On 5.10.2011 5:32, RJ Ryan wrote:

Committed to lp:mixxx so it will be part of 1.10.0.

How should I credit your name in the contributors list? Is "Peter
Vágner" alright?

Thanks again,
RJ Ryan

** Changed in: mixxx
Assignee: (unassigned) => pvagner (peter-v)

** Changed in: mixxx
Milestone: None => 1.10.0

** Changed in: mixxx
Status: Confirmed => Fix Committed

[mixxxbot]

Commented by: rryan
Date: 2011-10-05T16:32:53Z

---

Great -- added the tabChangesFocus to the QTextEdit in shoutcast and track property dialogs and tested it works.

Thanks,
RJ

[mixxxbot]

Issue closed with status Fix Released.