update xwax to 1.2

[mixxxbot]

Reported by: ywwg
Date: 2011-11-09T16:36:51Z
Status: Fix Released
Importance: Undecided
Launchpad Issue: lp888155

---

Xwax has released version 1.0, bring that into mixxx so we're up to date. (also need to check for api changes, etc)

[mixxxbot]

Commented by: starlily
Date: 2012-09-20T04:59:57Z

---

xwax is now on version 1.2 as of March :)

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T01:56:33Z

---

How time flies! :)

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T15:41:33Z

---

Done and tested with Serato and Traktor V1 Vinyl

(lp:mixxx/1.11 commit 3413)

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T15:42:48Z

---

Ah I misread the bug report and put this in the wrong branch -- the API changes are very minor, however (check out diff to vinylcontrolxwax.cpp) -- should I revert the commit?

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T15:58:01Z

---

Nope -- I just figured you didn't have time before the 1.11.0 release. Thanks!

Instead of Q_ASSERT'ing in VinylControlXwax is there a way to fail gracefully (i.e. just disable vinyl control or something?). I'm trying to get rid of all the Q_ASSERTs.

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T15:59:54Z

---

Also, the Windows build is broken :).
http://builds.mixxx.org/jenkins/job/mixxx-1.11-release-windows/architecture=i386,os=windows/107/console

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T16:03:06Z

---

stdbool.h isn't available on Windows and the diff has this in timecoder.h:
-#ifndef _MSC_VER
 #include <stdbool.h>
-#endif

I assume because Windows is not supported? Or maybe this is a patch we put in place on top of xwax.

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T16:30:51Z

---

Good catch, yeah we tweaked the file a bit for windows. I should really make a diff that I can just apply to xwax's source to make this easier.

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T16:42:45Z

---

Fixes applied. The vinyl control code currently doesn't have a failure mode, so I did what we do elsewhere and default to serato side A.

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T17:28:18Z

---

OK the build server finally likes the win32 versions of the files now. I'm going to make a diff so this doesn't happen again

[mixxxbot]

Commented by: ywwg
Date: 2012-09-26T17:28:19Z

---

OK the build server finally likes the win32 versions of the files now. I'm going to make a diff so this doesn't happen again

[mixxxbot]

Issue closed with status Fix Released.