support pushbutton EQ kill switches instead of toggle

[mixxxbot]

Reported by: q-enkidu
Date: 2012-01-19T00:01:28Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp918470
Attachments: kill_switch_pw_style.patch

---

Right now killswitches can be only toggled, for some usages (future multitouch maybe) it could be nice to enable them only while pressed (for example - right click).

[mixxxbot]

Commented by: esbrandt
Date: 2012-02-05T12:36:11Z

---

This is already possible with modifications to the skin definition file.
Although one would have to decide between active while pressed/ toggle behavior.

[mixxxbot]

Commented by: esbrandt
Date: 2012-03-13T08:40:14Z

---

Update:
If the "Power window" behavior ( see lp:876139 )is implemented in 1.11 it will work like this:
Short push: enable EQ kill
Second short push: disable EQ kill
Long push t > 0,5 s: EQ kill while button down

TODO: Update skins tooltips to reflect the new functionality if patch get merged.

[mixxxbot]

Commented by: daschuer
Date: 2012-04-21T19:57:01Z
Attachments: kill_switch_pw_style.patch

---

The attached patch changes all EQ kill switches in all skins to power window style.
The patch of bug #⁠876139 is required.

[mixxxbot]

Commented by: rryan
Date: 2012-05-01T06:08:09Z

---

Note that Bug #876139 is now committed, though the <PowerWindowStyle> block is not necessary.

[mixxxbot]

Commented by: rryan
Date: 2012-05-01T06:08:43Z

---

Also, this patch doesn't change the kill-switches to be power-window style in src/engine/enginefilterblock.cpp.

[mixxxbot]

Commented by: esbrandt
Date: 2012-05-01T11:18:02Z

---

RJ Could you please explain your comment from #⁠5?
When i apply Daniels patch to the skins (see example), the kill buttons do not have the desired behavior, they work as toggle just as before.
Generally the Power window behavior does work, as i have successfully adapted the patch to the talkover button.

Example (just as in the patch)
<PushButton>
	<Tooltip></Tooltip>
	<Style></Style>
	<NumberStates>2</NumberStates>
	<State>
		<Number>0</Number>
		<Pressed>btn_kill_over.png</Pressed>
		<Unpressed>btn_kill.png</Unpressed>
	</State>
	<State>
		<Number>1</Number>
		<Pressed>btn_kill_over.png</Pressed>
		<Unpressed>btn_kill_over.png</Unpressed>
	</State>
	<Pos>73,159</Pos>
	<Connection>
		<ConfigKey>[Channel1],filterHighKill</ConfigKey>
		<EmitOnPressAndRelease>true</EmitOnPressAndRelease>
		<ButtonState>LeftButton</ButtonState>
	</Connection>
</PushButton>

[mixxxbot]

Commented by: rryan
Date: 2012-05-01T14:19:25Z

---

Yup, that was what my comment was about. These changes also need to be made:

=== modified file 'mixxx/src/engine/enginefilterblock.cpp'
--- mixxx/src/engine/enginefilterblock.cpp      2012-05-01 05:59:37 +0000
+++ mixxx/src/engine/enginefilterblock.cpp      2012-05-01 14:15:50 +0000
@@ -71,15 +71,15 @@

     filterpotLow = new ControlLogpotmeter(ConfigKey(group, "filterLow"), 4.);
     filterKillLow = new ControlPushButton(ConfigKey(group, "filterLowKill"));
-    filterKillLow->setButtonMode(ControlPushButton::TOGGLE);
+    filterKillLow->setButtonMode(ControlPushButton::POWERWINDOW);

     filterpotMid = new ControlLogpotmeter(ConfigKey(group, "filterMid"), 4.);
     filterKillMid = new ControlPushButton(ConfigKey(group, "filterMidKill"));
-    filterKillMid->setButtonMode(ControlPushButton::TOGGLE);
+    filterKillMid->setButtonMode(ControlPushButton::POWERWINDOW);

     filterpotHigh = new ControlLogpotmeter(ConfigKey(group, "filterHigh"), 4.);
     filterKillHigh = new ControlPushButton(ConfigKey(group, "filterHighKill"));
-    filterKillHigh->setButtonMode(ControlPushButton::TOGGLE);
+    filterKillHigh->setButtonMode(ControlPushButton::POWERWINDOW);

[mixxxbot]

Commented by: rryan
Date: 2012-05-01T14:20:30Z

---

I went ahead and added that patch I just posted in #⁠7 so the skin updates from Daniel's original patch in this bug report should work now.

[mixxxbot]

Issue closed with status Fix Released.