Create mix record fail in music library(path with non-ascii character)

[mixxxbot]

Reported by: jacksjy
Date: 2012-02-22T13:02:40Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp938648
Attachments: recording_non_ascii.patch

---

under Ubuntu 10.04

If the path to the music library contain non-ascii character.

(like /home/user/音乐)

Record Mix function in Mixxx can't handle correctly with the path.

And popup file create fail dialog, cause by permission or not enough

disk space.

but folder Mixxx/Recordings can create under such path.

################################################

$locale  

LANG=zh_CN.UTF-8
LANGUAGE=zh_CN:en
LC_CTYPE="zh_CN.UTF-8"
LC_NUMERIC="zh_CN.UTF-8"
LC_TIME="zh_CN.UTF-8"
LC_COLLATE="zh_CN.UTF-8"
LC_MONETARY="zh_CN.UTF-8"
LC_MESSAGES="zh_CN.UTF-8"
LC_PAPER="zh_CN.UTF-8"
LC_NAME="zh_CN.UTF-8"
LC_ADDRESS="zh_CN.UTF-8"
LC_TELEPHONE="zh_CN.UTF-8"
LC_MEASUREMENT="zh_CN.UTF-8"
LC_IDENTIFICATION="zh_CN.UTF-8"
LC_ALL=

[mixxxbot]

Commented by: daschuer
Date: 2012-02-24T20:18:59Z
Attachments: recording_non_ascii.patch

---

the attached patch solves the problem for lp:mixxx #⁠2987.
It was tested on ubuntu lucid only.

[mixxxbot]

Commented by: rryan
Date: 2012-03-12T20:46:43Z

---

Hey Daniel,

I see you use toLocal8Bit() as the argument to sf_open. In src/soundsourcesndfile.cpp you'll see that on Windows we use toLocal8Bit() but on all others we use toUtf8().

Does toUtf8() work as well? Even if it does, I'd prefer we duplicate the logic in src/soundsourcesndfile.cpp unless you know of a reason not to.

Also, we should probably get people to test this on Windows, Mac and Linux before committing.

[mixxxbot]

Commented by: daschuer
Date: 2012-03-13T21:30:37Z

---

Hi RJ

toLocal8Bit does the Magic:

• on Linux its result is equal to toUtf8()
• on Windows it is equal to toLatin1() in my case.

Regards,

Daniel

[mixxxbot]

Commented by: rryan
Date: 2012-03-13T22:07:44Z

---

Here's the implementation of toLocal8Bit():
https://qt.gitorious.org/qt/qt/blobs/4.8/src/corelib/tools/qstring.cpp#line3763

So as the name implies it's locale dependent. I wonder this could ever
cause problems in a locale where the default is not either UTF-8 or Latin1.
Maybe we could look for someone whose system locale is JIS/KOI/etc. to
confirm?

2012/3/13 Daniel Schürmann <email address hidden>

Hi RJ

toLocal8Bit does the Magic:

• on Linux its result is equal to toUtf8()
• on Windows it is equal to toLatin1() in my case.

Regards,

Daniel

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/938648

Title:
Create mix record fail in music library(path with non-ascii
character)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/938648/+subscriptions

[mixxxbot]

Commented by: rryan
Date: 2012-03-14T05:13:03Z

---

I went ahead and committed the patch. If it fails we'll probably hear about it.

[mixxxbot]

Issue closed with status Fix Released.