Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable searching for tracks in a range of bpms #6283

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

Enable searching for tracks in a range of bpms #6283

mixxxbot opened this issue Aug 22, 2022 · 6 comments
Labels
duplicate This issue is a duplicate of or superseded by another issue. feature
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ywwg
Date: 2012-02-23T21:47:02Z
Status: In Progress
Importance: Wishlist
Launchpad Issue: lp939845
Attachments: search_bpm.diff


It would be nice to search for tracks of a certain bpm range. Here's a patch that does it!

Just type a term in the form "120-140" (no spaces) in the search box. The patch looks for the hyphen and then looks for two integers on either side. If any of these requirements isn't satisfied the term is treated as a regular search term.

@mixxxbot mixxxbot added duplicate This issue is a duplicate of or superseded by another issue. feature labels Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2012-02-23T21:47:02Z

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2012-02-23T21:53:23Z
Attachments: search_bpm.diff


Whoops typo, forgot to initialize a variable.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-02-26T10:38:10Z


Thanks Owen, tested and works like a charm.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-03-12T20:30:23Z


The patch looks good to me except I'd prefer that we make the user be a little more explicit about searching by BPM.

Bart did some work on this for his GSoC project but it hasn't been merged yet. So that people don't have to learn the new way when his branch merges, I think it'd be better if this patch matched the behavior of the advanced search branch.

Doing this just means checking for a "bpm:" prefix. For example:

[com truise bpm:110-120]

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-03-28T04:42:03Z


Trunk now has the ability to do queries like:

bpm:140.5-150.235
bpm:>140
bpm:<=140
bpm:>140.5

@mixxxbot
Copy link
Collaborator Author

Duplicate of #5572

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.10.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate of or superseded by another issue. feature
Projects
None yet
Development

No branches or pull requests

1 participant