Hercules RMX effect knobs don't work

[mixxxbot]

Reported by: jhartle13
Date: 2012-03-16T01:36:25Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp956625
Attachments: 956625.patch

---

OS: Mac OSX 10.7.3
Processor: 2.8 GHz Intel Core i7
Video: NVIDIA GeForce GT 330M 512 MB

When using the Hercules DJ Console RMX Advanced mapping, i will hold the button labeled "Scratch" to use as a shift function that is supposed to change the functions of the Bass, Mid, and Treble hardware knobs to control the Lfo, Depth, and Delay effect knobs. every time I try, I get an error popup that says:

Uncaught exception at line 446 in file /Applications/Mixxx.app/Contents/MacOS/../Resources/midi/Hercules-DJ-Console-RMX-scripts.js: ReferenceError: Can't find variable: Controls

I got the instructions for this supposed functionality from:

http://www.mixxx.org/wiki/doku.php/hercules_dj_console_rmx

This is an extremely important feature for me. If you could look into it for me that would be most appreciated.
Thanks

[mixxxbot]

Commented by: bencoder
Date: 2012-03-28T08:19:32Z

---

Hi Jon,

I don't have an RMX so I can't confirm if this will fix the issue, but could you try changing three lines in that script file and retesting:

/Applications/Mixxx.app/Contents/MacOS/../Resources/midi/Hercules-DJ-Console-RMX-scripts.js

Change these three lines:

Controls.FlangerDepth.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerDepth.setValue("[Flanger]", value);

Controls.FlangerDelay.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerDelay.setValue("[Flanger]", value);

Controls.FlangerPeriod.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerPeriod.setValue("[Flanger]", value);

(In my file these are on lines 460, 474 and 488, but the error message you gave indicates that the line was 446, so you might have a slightly different version of the script)

Please report back whether this change fixes the problem so that we can make it official and fix it for the next version!

Thanks very much,
Ben

[mixxxbot]

Commented by: jhartle13
Date: 2012-03-29T05:09:26Z

---

Ben,

Thanks for addressing this so quickly, I really appreciate it. These fixes took care of the problem I was having. System works great now.

Thanks very much,
Jon

On Mar 28, 2012, at 2:19 AM, Ben Clark wrote:

Hi Jon,

I don't have an RMX so I can't confirm if this will fix the issue, but
could you try changing three lines in that script file and retesting:

/Applications/Mixxx.app/Contents/MacOS/../Resources/midi/Hercules-DJ-
Console-RMX-scripts.js

Change these three lines:

Controls.FlangerDepth.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerDepth.setValue("[Flanger]", value);

Controls.FlangerDelay.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerDelay.setValue("[Flanger]", value);

Controls.FlangerPeriod.setValue("[Flanger]", value);
to
HerculesRMX.Controls.FlangerPeriod.setValue("[Flanger]", value);

(In my file these are on lines 460, 474 and 488, but the error message
you gave indicates that the line was 446, so you might have a slightly
different version of the script)

Please report back whether this change fixes the problem so that we can
make it official and fix it for the next version!

Thanks very much,
Ben

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/956625

Title:
Hercules RMX effect knobs don't work

Status in Mixxx:
New

Bug description:
OS: Mac OSX 10.7.3
Processor: 2.8 GHz Intel Core i7
Video: NVIDIA GeForce GT 330M 512 MB

When using the Hercules DJ Console RMX Advanced mapping, i will hold
the button labeled "Scratch" to use as a shift function that is
supposed to change the functions of the Bass, Mid, and Treble hardware
knobs to control the Lfo, Depth, and Delay effect knobs. every time I
try, I get an error popup that says:

Uncaught exception at line 446 in file
/Applications/Mixxx.app/Contents/MacOS/../Resources/midi/Hercules-DJ-
Console-RMX-scripts.js: ReferenceError: Can't find variable: Controls

I got the instructions for this supposed functionality from:

http://www.mixxx.org/wiki/doku.php/hercules_dj_console_rmx

This is an extremely important feature for me. If you could look into it for me that would be most appreciated.
Thanks

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/956625/+subscriptions

[mixxxbot]

Commented by: bencoder
Date: 2012-03-30T18:05:00Z
Attachments: 956625.patch

---

Hi Jon,
Thanks very much for the swift testing and response!

I've attached a patch for this fix for release in the next version.

Ben

[mixxxbot]

Commented by: rryan
Date: 2012-03-30T18:12:27Z

---

Thanks Ben!

[mixxxbot]

Issue closed with status Fix Released.