Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing visual gain in preferences does not affect "Filtered" display type #6422

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: broma0-deactivatedaccount
Date: 2012-05-10T02:33:14Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp997435


While using the filtered or simple GL display type, changing the visual gain settings does not change the waveform at all. The settings work as normal when using filtered GL display type.

These settings are the most useful while using the filtered display type which with normal settings doesn't provide enough detail.

Note - Filtered GLSL was not mentioned because the waveform isn't visible when it's selected, this is a different bug all together.

My system - Arch Linux 64 bit, Gnome Shell 3.4

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: vrince
Date: 2012-05-10T17:31:48Z


Yeah I know I was lazy ... I need to make it work in all waveforms. I am on it ...
Some are already fixed in the waveform-2.0_pure-gl branch, I'll do it in this branch and it should be merged soon.

@mixxxbot
Copy link
Collaborator Author

Commented by: broma0-deactivatedaccount
Date: 2012-05-10T22:32:29Z


That would be awesome. That's the only think keeping me from using trunk
On May 10, 2012 1:40 PM, "Thomas Vincent" <email address hidden> wrote:

Yeah I know I was lazy ... I need to make it work in all waveforms. I am
on it ...
Some are already fixed in the waveform-2.0_pure-gl branch, I'll do it in
this branch and it should be merged soon.

** Changed in: mixxx
Status: New => Confirmed

** Changed in: mixxx
Importance: Undecided => Medium

** Changed in: mixxx
Assignee: (unassigned) => Thomas Vincent (vrince)

** Changed in: mixxx
Milestone: None => 1.11.0

** Changed in: mixxx
Status: Confirmed => In Progress

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/997435

Title:
Changing visual gain in preferences does not affect "Filtered" display
type

Status in Mixxx:
In Progress

Bug description:
While using the filtered or simple GL display type, changing the
visual gain settings does not change the waveform at all. The settings
work as normal when using filtered GL display type.

These settings are the most useful while using the filtered display
type which with normal settings doesn't provide enough detail.

Note - Filtered GLSL was not mentioned because the waveform isn't
visible when it's selected, this is a different bug all together.

My system - Arch Linux 64 bit, Gnome Shell 3.4

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/997435/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: broma0-deactivatedaccount
Date: 2012-05-17T00:41:17Z


What's the status on this one? I think this might also fix this bug as well

** Changed in: mixxx
Status: Fix Committed => In Progress

** Branch linked: lp:~vrince/mixxx/waveform-2.0_pure-gl

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/997435

Title:
Changing visual gain in preferences does not affect "Filtered" display
type

Status in Mixxx:
In Progress

Bug description:
While using the filtered or simple GL display type, changing the
visual gain settings does not change the waveform at all. The settings
work as normal when using filtered GL display type.

These settings are the most useful while using the filtered display
type which with normal settings doesn't provide enough detail.

Note - Filtered GLSL was not mentioned because the waveform isn't
visible when it's selected, this is a different bug all together.

My system - Arch Linux 64 bit, Gnome Shell 3.4

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/997435/+subscriptions

--
Matt Brooks

@mixxxbot
Copy link
Collaborator Author

Commented by: vrince
Date: 2012-05-17T12:37:15Z


This bug is fix in pure-gl branch, should be merge pretty soon.
#⁠976650 is another issue related to how waveform data is computed.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant