Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no change of searchbox contend when changing library feature #6435

Closed
mixxxbot opened this issue Aug 22, 2022 · 9 comments
Closed

no change of searchbox contend when changing library feature #6435

mixxxbot opened this issue Aug 22, 2022 · 9 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2012-05-13T17:46:41Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp998836
Attachments: searchbox_refresh.patch, [BZR Log - Mixxx_trunk.png](https://bugs.launchpad.net/bugs/998836/+attachment/3178148/+files/BZR Log - Mixxx_trunk.png)


The serachbox does not display the current search (filter) when moving through the library tree in any case.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-05-13T21:05:54Z
Attachments: searchbox_refresh.patch


the attached patch solves the problem for lp:mixxx #⁠3154.
Bug #⁠995957 is also solved by this patch.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-05-14T05:35:40Z


We had a discussion about that some month back, we could take the chance and decide now what is the preferred behavior https://bugs.launchpad.net/mixxx/+bug/689291

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-05-14T06:16:15Z


This bug is an issues only for the current behavior.
This is, that every feature saves its current search.

Without the patch, the searchbox is not properly refreshed when moving through the library. This is annoying because sometimes simply a wrong filter is displayed.

I would prefer to commit this patch and to postpone the general thing until we renovating the library view.

I will add my additional comments to Bug #⁠689291.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-06-05T15:09:56Z


There seem to be a few stray tab characters in the patch but otherwise looks good to me (and since it fixes current intended behavior it can go in independent of the discussion in Bug #⁠689291)

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-06T19:41:38Z


Committed lp:mixxx #⁠3247

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-06-06T20:11:22Z
Attachments: [BZR Log - Mixxx_trunk.png](https://bugs.launchpad.net/mixxx/+bug/998836/+attachment/3178148/+files/BZR Log - Mixxx_trunk.png)


Hi Daniel, just FYI.
It looks like your latest fixes to trunk were committed without the " --fixes lp:XXXXX" option. Because of this the fixed bugs are not automatically linked to the respective branch ( e.g. lp:mixxx ) and are not searchable by bug# with bazaars log function (see screenshot).
http://doc.bazaar.canonical.com/beta/en/tutorials/using_bazaar_with_launchpad.html#changing-the-state-in-launchpad-while-committing-in-bazaar

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-06T20:30:35Z


Hi jus, thank you for the hint!

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-24T10:03:36Z


Merged to lp:mixxx/1.10 #⁠3107

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant