Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting mixxx should close the preference dialog #6499

Closed
mixxxbot opened this issue Aug 22, 2022 · 4 comments
Closed

Quitting mixxx should close the preference dialog #6499

mixxxbot opened this issue Aug 22, 2022 · 4 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kwhat
Date: 2012-06-02T21:37:09Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1007958
Attachments: closePrefs.diff, closePrefs2.diff


Closing mixxx does not work if the preference dialog is open, it closes the main window but music continues to play until the dialog is closed. Either a modal dialog should be used or the window should be closed on exit.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: mutil
Date: 2012-06-12T23:07:44Z
Attachments: closePrefs.diff


Attaching a small patch which addresses this issue.
It also partially solves bug lp:1007832 as it shows a warning dialog when preferences window is open upon closing.

@mixxxbot
Copy link
Collaborator Author

Commented by: mutil
Date: 2012-06-12T23:32:39Z
Attachments: closePrefs2.diff


Sorry, this had to be inside confirmExit() function to better fit the code.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-06-20T08:48:04Z


Thanks for the patch, works likes a charm.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant