Enabling keylock on playing track resets key

[mixxxbot]

Reported by: hile
Date: 2012-07-19T12:18:05Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1026590

---

If you enable keylock on a playing track with rate fader not in center position, the key jumps to 0 value.

This sounds quite bad if you are playing the track, and besides doesn't feel like correct choice anyway: if user has set the key with rate fader, it would seem to make more sense to keep current key when locked. I propose we at least add an option to keep the current key in such case, or make it default.

One issue I see with keeping the key is what should happen if pitch slider is moved after activating keylock and keylock is disabled again: maybe the key should jump to value matching the slider position in this case?

[mixxxbot]

Commented by: ywwg
Date: 2012-07-19T17:56:05Z

---

This is actually a tricky fix, even though it wouldn't be a ton of lines of code. It will involve talking to SoundTouch and setting both the tempo and pitch parameters such that the pitch is the same as the previous value, but the tempo is too. (Right now I think Mixxx just sets the tempo and leaves the pitch alone). I'm not sure what the interaction is between the two variables, so I'm not sure what to set for the right behavior.

[mixxxbot]

Commented by: esbrandt
Date: 2014-01-01T11:46:30Z

---

Currently discussed in lp:1258617

[mixxxbot]

Commented by: daschuer
Date: 2014-04-01T06:15:58Z

---

Now the key locks "locks" the pitch at the current pitched key. So the original bug is fixed.
I think RJ has done it, so I will assign the bug to him.

[mixxxbot]

Issue closed with status Fix Released.