leaks from valgrind analysis

[mixxxbot]

Reported by: daschuer
Date: 2012-07-21T22:56:31Z
Status: Fix Released
Importance: Undecided
Launchpad Issue: lp1027515
Attachments: leak.patch, crash.txt, mutexLogFile.patch

---

attached a patch sealing some leaks detected by valgrind in 1.11

[mixxxbot]

Commented by: daschuer
Date: 2012-07-21T22:56:31Z
Attachments: leak.patch

[mixxxbot]

Commented by: rryan
Date: 2012-07-21T23:10:45Z

---

thanks daniel -- looks good to me
On Sat, Jul 21, 2012 at 6:56 PM, Daniel Schürmann <
<email address hidden>> wrote:

** Patch added: "leak.patch"

https://bugs.launchpad.net/bugs/1027515/+attachment/3231441/+files/leak.patch

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1027515

Title:
leaks from valgrind analysis

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1027515/+subscriptions

[mixxxbot]

Commented by: daschuer
Date: 2012-07-23T21:46:33Z

---

commited to lp:mixxx/1.11 #⁠3323

[mixxxbot]

Commented by: ywwg
Date: 2012-07-24T17:35:07Z
Attachments: crash.txt

---

I'm getting crashes, I think because of this patch. Log attached.

[mixxxbot]

Commented by: daschuer
Date: 2012-07-24T21:17:46Z
Attachments: mutexLogFile.patch

[mixxxbot]

Commented by: daschuer
Date: 2012-07-24T21:28:06Z

---

I don't get the point why the patch causes the crash, maybe its a timing issue.

But anyhow .. The attached patch solves a race condition when a thread tries to write to the logfile when it is about to be close by main.

I cannot reproduce the crash on Ubuntu Lucid. Was this actually tested with lp:mixxx/1.11?
I have no such a message in my log: "QThread: Destroyed while thread is still running"

It seams there is an additional bug on the destructor procedure of EngineWorkerScheduler.

Any clue which tread is still running?

[mixxxbot]

Commented by: ywwg
Date: 2012-07-24T23:09:50Z

---

I'll debug this more and see if I can figure it out.

[mixxxbot]

Issue closed with status Fix Released.