Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default Sample Rate to PA default (most likely 44100 Hz) #6747

Closed
mixxxbot opened this issue Aug 22, 2022 · 11 comments
Closed

default Sample Rate to PA default (most likely 44100 Hz) #6747

mixxxbot opened this issue Aug 22, 2022 · 11 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2012-12-05T21:26:29Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1087002
Attachments: defaultSampleRate.patch


I wonder why Mixxx has 48000 Hz sample rate by default.
All of my tracks are at 44100 Hz. (Audio CD)
(Likely such as the mayority of Mixxx users)

What is the reason for 48000 Hz default?

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-12-05T21:44:10Z


It was an arbitrary decision a long time ago. It's true that doing
samplerate conversions (e.g. from 44.1 -> 48) means that we do more CPU
work and it decreases audio quality (though the effect on both CPU and
quality are likely small).

On Wed, Dec 5, 2012 at 4:26 PM, Daniel Schürmann <

wrote:

Public bug reported:

I wonder why Mixxx has 48000 Hz sample rate by default.
All of my tracks are at 44100 Hz. (Audio CD)
(Likely such as the mayority of Mixxx users)

What is the reason for 48000 Hz default?

** Affects: mixxx
Importance: Undecided
Status: New

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1087002

Title:
default to 44100 Hz

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1087002/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2012-12-05T21:50:23Z


Good question. I also added special code which causes mixxx to do no sound-stretching on audio material when it matches the sample rate, so in the jukebox situation (tracks always playing at 1.0 speed), 44.1 might be a better choice than 48 for sound quality purposes.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2012-12-06T06:48:34Z


What is the reason for 48000 Hz default?

Some cheap sound cards support only this rate natively so for users with such cards, Mixxx would fail to work on first run.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2012-12-06T06:50:20Z


...if the default was anything else. Ideally, Mixxx should sequence through all of the available sample rates if the last-selected one results in being unable to open the sound card.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-01-03T13:45:03Z


http://www.portaudio.com/docs/proposals/002-ImproveDeviceFormatsQueryInterface.html

This explains how Pa thinks about it.

IMO, we should rely on PA default sample rate which will be 44100 Hz in most cases.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-01-03T20:26:08Z
Attachments: defaultSampleRate.patch


Here is a patch, picks the PA default sample rate as Mixxx default.
I would like to commit this to 1.11 since it effects (only) new users.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-01-05T09:01:57Z


I can't comment on the technical aspects discussed here, but on support request we got in the forums and the feedback form.

Often new user on (mostly) Windows complain that a) Mixxx did not load any tracks or b) plays tracks to slow. Manually selecting a valid sound device in the preferences and setting the sample rate to 44100 Hz works in most of the cases.

One could argue that we never heard from the users with cheap 48k only sound cards (see #⁠3) because they have no issues, but as long as we dont have any numbers it is speculation.

One aspect that we should not overlook in this context is that none of our competitors (afaik) default to 48k. Here we can probably trust the majority, also because some of them are hardware makers too.

+1 for defaulting to 44.1k

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-01-05T09:49:25Z


Just changed the Bug Title.
The patch dos not explicit request 44100 Hz, but it try the PA default first, which is most likely 44100 Hz if it is possible.
If 44100 is not possible PA will perform the re-sampling or pick a different default.
What actually happen is untested.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-01-15T21:28:51Z


Commited to lp:mixxx/1.11 #⁠3675

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2013-01-30T05:23:06Z


+1 to relying on PortAudio for the sample rate. The patch looks good to me.

On Sat, Jan 5, 2013 at 4:01 AM, jus wrote:

I can't comment on the technical aspects discussed here, but on support
request we got in the forums and the feedback form.

Often new user on (mostly) Windows complain that a) Mixxx did not load
any tracks or b) plays tracks to slow. Manually selecting a valid sound
device in the preferences and setting the sample rate to 44100 Hz works
in most of the cases.

One could argue that we never heard from the users with cheap 48k only
sound cards (see #⁠3) because they have no issues, but as long as we dont
have any numbers it is speculation.

One aspect that we should not overlook in this context is that none of
our competitors (afaik) default to 48k. Here we can probably trust the
majority, also because some of them are hardware makers too.

+1 for defaulting to 44.1k

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1087002

Title:
default to 44100 Hz

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1087002/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant