Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in AutoDJ and Analyse should be styled #6822

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

Buttons in AutoDJ and Analyse should be styled #6822

mixxxbot opened this issue Aug 22, 2022 · 6 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kain88-de
Date: 2012-12-31T17:36:29Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1094928
Tags: skin
Attachments: text3011.png, looks.patch


I found that the buttons could be styled with a stylesheet. I would like if these buttons are styled in new skins because these buttons look a bit strange right now because they don't follow the ususal styling of the skin.

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2012-12-31T17:36:29Z
Attachments: text3011.png

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2012-12-31T17:36:49Z
Attachments: looks.patch

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-01-01T13:35:38Z


Qt provides standard widgets that look like those described in the interface guidelines for the respective operating system. We use some of them, e.g. (radio)button, tableheader, scrollbar. Your patch may work on Win, but makes the button an alien on other OS. If we choose to customize the look of standard widgets, we must do so for all elements. The Spartan skin in the forums is an example. The potential problem with this approach is, that it may not work with skins that use the color scheme architecture (untested).

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-01-01T14:22:49Z


I've tried it on Linux. From my experience it will look the same on any OS if the buttons are styled in the skin.xml, the new preview button is a example for this. The Spartan skins does what I'd like to see with the other skins as well, because unstyled they look a bit out of place for me.

I also tested the patch with the outline skin without problems.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2015-11-27T08:23:06Z


Fixed in Deere skin

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants