Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler track lable overwrites in Shade skin #6846

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

Sampler track lable overwrites in Shade skin #6846

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2013-01-15T22:51:17Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1100071
Tags: skin
Attachments: TrackLable.png


See attached

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-01-15T22:51:17Z
Attachments: TrackLable.png

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-01-19T10:14:09Z


After some testing, i found that it affects all skins with sampler decks.
If you just start up Mixxx and load a track with long metadata to the sampler deck, its fine. But if you switch a skin, the Artist/Title display expands. The <Text> key has a fixed size, but expands on skin change inside the Sampler's <WidgetGroup>, overwriting the other elements.

Text displayed using the <TrackProperty> key (like on the decks), are unaffected. So i guess  <Text> needs some tweaking in the skin parser. As a workaround, i try to use an extra fixed size tag inside the <Text> key's <Size> attribute.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-01-19T12:26:03Z


Workaround committed to http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/1.11-skins/revision/3185

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2013-01-19T13:18:24Z


Correction to mixxxdj/mixxx#4911
It does affect text displayed using the <TrackProperty> key. Need to add the workaround there too.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants