New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no color scheme for waveform marks #6867

Closed

mixxxbot opened this issue Aug 22, 2022 · 5 comments

Labels

bug

Milestone

Collaborator

mixxxbot commented Aug 22, 2022

Reported by: daschuer
Date: 2013-01-27T22:37:12Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1107249
Attachments: markscolors.patch

The colors of the waveform marks are not translated by the color scheme

mixxxbot added the bug label

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: daschuer
Date: 2013-03-23T18:50:56Z
Attachments: markscolors.patch

after all, here is a patch against lp:mixxx/1.11 r3779

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: esbrandt
Date: 2013-03-25T03:05:47Z

Thanks, tested and confirmed working with latest lp:mixxx/1.11

Note:
I got now a bunch of warnings in the logs. Related?
src/skin/imgsource.h:30: warning: unused parameter 'p'
src/skin/imgsource.h:42: warning: unused parameter 'p'

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: rryan
Date: 2013-03-27T01:03:08Z

Looks good - thanks Daniel!

Collaborator Author

mixxxbot commented Aug 22, 2022

Commented by: daschuer
Date: 2013-03-27T21:34:22Z

committed to lp:mixxx/1.11 revision 3782.
and fixed warnings from #⁠2

Collaborator Author

mixxxbot commented Aug 22, 2022

Issue closed with status Fix Released.

mixxxbot closed this as completed

mixxxbot transferred this issue from another repository

mixxxbot added this to the 1.11.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment