Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slip mode exit should cause Mixxx to ignore jog wheel until it stops sending midi notes #6930

Open
mixxxbot opened this issue Aug 22, 2022 · 4 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: broma0-deactivatedaccount
Date: 2013-02-27T16:46:09Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1134544


I'd like to be able to do this:

  1. Put a deck into slip mode
  2. Spin the jog wheel back
  3. Exit slip mode while the wheel is still spinning
  4. Song immediately continues to play from the "un-slipped" part of the track.

What actually happens:

  1. Put a deck into slip mode
  2. Spin the jog wheel back
  3. Exit slip mode while the wheel is still spinning
  4. Song continues to play from the "un-slipped" part of the track AFTER THE JOG WHEEL STOPS SPINNING
    --- The song seeks to where it should be, then begins to spin back because the jog is still sending midi notes

I would essentially like Mixxx to ignore midi notes from a spinning jog wheel on slip mode exit until that wheel stops sending midi notes.

@mixxxbot
Copy link
Collaborator Author

Commented by: borfo
Date: 2013-03-20T03:11:27Z


Here's one way this might be accomplished: It would be nice to have something like a "control stopped" event that would fire when a particular control stops moving (ie: no data from it in a certain number of milliseconds - maybe you could set the threshold for this arbitrarily somehow), that you could hook a function to with engine.connectcontrol... Then, at the point in the script where you call the exit from slip mode, you could disable the wheel input, and re-enable it in a function connected to the "wheel stopped" event.

I can imagine uses for this other than for the wheel/slip mode thing - interesting functionality could be built around a "control stopped" function for knobs and faders as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-03-20T06:32:18Z


Yes, this could be universal solution.

I experience problems with the touch sensitive wheel of the RMX2 Controller.

Touched = Scratch
Not Touched = Jog

But while scratching it sometimes happens that that you accidentally release the pressure and you are back in jog mode.

Whit such a "control stopped" event we may script around it.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2013-03-20T06:59:51Z


I'll take a closer look at this when I have some time, but for now, can you guys take a look at the wheel script functions in the Reloop TerminalMix4 preset I created? (I think the American Audio VMS4 preset does it too.) They feature the ability to do a spinback and the effect remains engaged even if you stop touching the wheel, until it stops moving, then the track resumes playback, exactly as would happen with a moving platter.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2013-03-20T07:11:32Z


Scratch that... the functionality is already in the controller engine in Mixxx v1.11 so it should just work. If it's not, then the added brake & spinback code might be affecting it.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@daschuer daschuer added the slip label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants