Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorschemes don't support new splitter/library/... widgets #6960

Closed
mixxxbot opened this issue Aug 22, 2022 · 4 comments
Closed

Colorschemes don't support new splitter/library/... widgets #6960

mixxxbot opened this issue Aug 22, 2022 · 4 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kain88-de
Date: 2013-03-24T16:04:11Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1159451
Tags: skin
Attachments: colorscheme.patch, colorscheme_v2.patch


I've looked a bit into this. It seems that for the colorschemes to work we have to set the library style manually on the widgetgroup that contains the library. This patch does this. It looks better now in the outline800x400 skin but onw of the alternating colors is still off.

It would also be nice if someone could test if the previewdeck now can be skinned in outline.

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-03-24T16:04:11Z
Attachments: colorscheme.patch

@mixxxbot
Copy link
Collaborator Author

Commented by: kain88-de
Date: 2013-03-25T20:17:51Z
Attachments: colorscheme_v2.patch


here is a patch with the preview deck in the skin. It looks a bit cramped though

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2013-03-27T00:42:13Z


Thanks for working on this Max. Instead of auto-detecting the legacy library I prefer that we just make legacy skins have to add a tag to the <WidgetGroup> containing the <Splitter>. I added a fix based on your patch that uses <LegacyTableViewStyle> to indicate the legacy styling should occur. Committed to lp:mixxx/1.11.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants