Make duration of end-of-track visualisation user configurable

[mixxxbot]

Reported by: dasy2k1
Date: 2013-03-25T21:32:58Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1160043
Tags: easy, waveform, weekend, wishlist
Attachments: 0005-Bug-1160043-Added-spinbox-slider-in-Prefrences-wavef.patch, 0006-Cleaning-code-a-bit.patch

---

The waveform flash that starts 30 seconds before the end of the track is a great feature but is a bit too long for me.. I would love to be able to change this in the settings (under the wavform display)

[mixxxbot]

Commented by: raulbehl
Date: 2014-09-20T05:47:08Z

---

Is anyone working on this? I'd like to work on this bug (or wish, rather) as my first contribution to Mixxx. Can I get any help on the same (potential source code to look into) ?

[mixxxbot]

Commented by: esbrandt
Date: 2014-09-21T09:16:42Z

---

The bug is not assigned to anyone at the moment.
Click on the "Unassigned" link to assign a bug to yourself
Finally, click on the "Assign Me" link (the little yellow exclamation point)
The bug is now assigned for you to work on it.

The developer documentation helps you getting started, see http://mixxx.org/wiki/doku.php#developer_documentation
Mixxx source is @ https://github.com/mixxxdj/mixxx
The end-of-track renderer is @ https://github.com/mixxxdj/mixxx/blob/master/src/waveform/renderers/waveformrendererendoftrack.cpp
Waveform preferences @ https://github.com/mixxxdj/mixxx/blob/master/src/dlgprefwaveform.cpp

Looking forward to your first contribution.

[mixxxbot]

Commented by: raulbehl
Date: 2014-10-06T16:18:37Z
Attachments: 0005-Bug-1160043-Added-spinbox-slider-in-Prefrences-wavef.patch

---

Can someone (Jus) please review this pull request:

#352

I have added a spin box and a slider (in options->preferences->waveform) to make end of the track flash user configurable. Currently, it ranges from 0 (no flash) to 60 secs before the end of the flash.

Any comments and suggestions to improve the current implementation are most welcome.

[mixxxbot]

Commented by: raulbehl
Date: 2014-10-06T16:21:18Z
Attachments: 0006-Cleaning-code-a-bit.patch

---

I forgot to add this patch too. Please check this too. :)
Cleaned and some changes. Not so major ones though.

[mixxxbot]

Issue closed with status Fix Released.