New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable keylock when scratching with scratch2_enable. #7008
Comments
Commented by: Pegasus-RPG If we want to do it across the board, why not just have the scratch2_enable CO do it when it's set to 1? |
Commented by: rryan Mouse scratching and vinyl control scratching don't use
|
Commented by: Pegasus-RPG I don't see why not. It doesn't make much sense to scratch with key lock on (unless someone thinks that's a cool effect,) so I'd say just go ahead. |
Commented by: ywwg I vote yes, we should do this for controllers. The code is already in there and there is no world where scratching while pitch-locked makes sense. |
Commented by: rryan |
Commented by: rryan I was worried about a controller getting stuck in scratch mode but Sean pointed out that if a controller gets stuck in scratch mode then it will most likely just stop so the preset and user have bigger problems in that case. :) |
Commented by: Pegasus-RPG Seems to work fine for me. The only improvement I'd make is to re-enable key lock during the ramp-up after releasing scratching because right now there's an abrupt change. |
Commented by: Pegasus-RPG Oh, one other use-case: moving-platter controllers that necessarily keep scratch2_enable on all the time (so the deck can accurately track the platter.) We need to provide a way for those controller scripts to make an exception to this auto-disable policy. (Currently that's just the SCS.1d and Numark NS7/V7.) I wonder if we should move the keylock-disable action to the controllerEngine::scratchEnable so we can add a parameter for keylockDisable? |
Commented by: rryan I rolled lp:mixxx r3855 -- Sean pointed out some issues that have convinced me this is not worth messing with right before a release with no beta testing :). |
Commented by: thomsen My initial description of this bug was this: Using Mixtrack Pro, Ubuntu 13.04 x64.
It only happens when KeyLock is on. The problem is not seen when scratching with the mouse. The changes in r3855 made the stuttering go away. With that rolled back, is there any way we can modify the controller script to mimic what happens in the engine? |
Commented by: rryan Releasing this bug to someone else. |
Commented by: rryan Any thoughts on this for 1.12.0? This is likely quite annoying for controller users. |
Commented by: rryan (not sure why I marked this Wishlist) |
Commented by: ywwg I think this is what we do already. Enginebuffer checks for is_scratching and disables keylock if is_scratching is true. and ratecontrol checks scratch2_enable when determining whether to set is_scratching. So I'll mark it fixed. If this is actively broken for someone we can reopen. |
Commented by: rryan RateControl doesn't set is_scratching for scratch2_enable, just for VC and scratch-controller (mouse scratching). See the patch I posted above -- it makes exactly that change (scratch2_enable triggers is_scratching true). |
Commented by: thomsen This bug was reported by Ryan after a discussion on IRC. The issue that I experienced (see comment #10) seems to be fixed in trunk! |
Commented by: ywwg So for the moving-platter controllers, how do we know if they are scratching or not? For vinyl I had to write a class that looked at the rates coming out and makes an educated guess: a certain amount of time with the rate not changing = not scratching. Do we have to write this for controllers? |
Issue closed with status Fix Released. |
Reported by: rryan
Date: 2013-04-29T22:57:52Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1174578
Tags: keylock, scratching
Attachments: controller_keylock.patch
We disable keylock for VC scratching and mouse scratching so we ought to do it for controller scratching as well.
Some controller scripts (i.e. the Mixtrack Pro preset) already do this in script.
The text was updated successfully, but these errors were encountered: