EQ kill buttons do not alter waveform

[mixxxbot]

Reported by: midzer
Date: 2013-05-10T20:15:18Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1178813
Tags: easy, eq
Attachments: my_changes.patch, my_changes.patch

---

EQ kill buttons do not alter new waveform appearance (should have same effect as EQ slider to zero)

[mixxxbot]

Commented by: rryan
Date: 2013-05-10T20:41:59Z

---

The kills only affect Filtered Qt-GL.

[mixxxbot]

Commented by: rryan
Date: 2013-05-10T20:53:49Z

---

Sorry, I meant this is only correct in Filtered (Qt-GL).

On Fri, May 10, 2013 at 4:41 PM, RJ Ryan wrote:

The kills only affect Filtered Qt-GL.

** Changed in: mixxx
Status: New => Confirmed

** Changed in: mixxx
Importance: Undecided => Low

** Changed in: mixxx
Milestone: None => 1.11.1

** Tags added: easy

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1178813

Title:
EQ kill buttons do not alter waveform

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1178813/+subscriptions

[mixxxbot]

Commented by: combesl
Date: 2013-09-04T01:19:05Z

---

EQ kill buttons do not alter waveform appearance, but this is not applicable in all types of waveform, because not all are affected by the EQ knobs.

Before fix the bug:

WORKS WELL:

• filtered - QT (GL)

DONT WORK (to fix):

• filtered software
• filtered (GL)

NO APPLICABLE (EQ knobs not affect waveform):

• simple - QT (GL)
• simple (GL)
• filtered - experimental (GLSL)
• HSV

I attach a patch to fix these (filtered software and filtered GL) waveforms.

[mixxxbot]

Commented by: combesl
Date: 2013-09-04T01:20:16Z
Attachments: my_changes.patch

[mixxxbot]

Commented by: daschuer
Date: 2013-09-04T07:10:09Z

---

Hi Leo,
thank you very much for your work.
We use double != 0.0 -> true conversion. Not 0.5.
Else your patch looks good!
If you like, you can issue a merge request on GitHub. This will simplify the review process.

Kind regards,
Daniel

[mixxxbot]

Commented by: combesl
Date: 2013-09-07T01:02:26Z

---

Thanks Daniel.

I have no idea if it is good.

#70

Applied double != 0.0.

[mixxxbot]

Commented by: combesl
Date: 2013-09-07T01:20:41Z
Attachments: my_changes.patch

---

Attach new patch just in case.

[mixxxbot]

Commented by: daschuer
Date: 2013-09-08T11:38:41Z

---

Bug is fixed in commit 1b165e2
1.12.0-alpha-pre (build master r3545)
Thank you Leo!

[mixxxbot]

Issue closed with status Fix Released.