Return keyboard shortcut makes [Playlist], ToggleSelectedSidebarItem stop working

[mixxxbot]

Reported by: uklotzde
Date: 2013-05-30T18:13:38Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1185926
Tags: 1.11, controls, midi, playlist

---

My Vestax VCI-300 controller script maps the following [Playlist] controls to buttons:

• SelectNextPlaylist
• SelectPrevPlaylist
• ToggleSelectedSidebarItem

When starting Mixxx the SelectNextPlaylist/SelectPrevPlaylist can be used for sidebar navigation. But after toggling a sidebar item with ToggleSelectedSidebarItem all those engine controls become unusable. I've verified that the values are correctly set by the controller script, but the engine doesn't recognize any further value changes.

I think those controls worked in the development versions for 1.11, but there seems to be a regression in the 1.11 release version.

OS used for testing: Ubuntu 13.04 64-bit

[mixxxbot]

Commented by: carl-barimore
Date: 2013-06-05T22:55:18Z

---

I've noted the same behaviour when using a Numark DJ2Go with the bundled Numark DJ2Go mapping (which also uses those three controls).

The three controls all work fine in 1.11 development builds up to bzr3821 (14 April). From bzr3836 (23 April), ToggleSelectedSidebarItem no longer works.

[mixxxbot]

Commented by: rryan
Date: 2014-03-24T22:14:39Z

---

I'll take a look.

[mixxxbot]

Commented by: rryan
Date: 2014-03-25T17:13:17Z

---

Ah -- Ok. So I think this was caused by introducing keyboard mappings for Return.

revno: 3823
fixes bug: https://launchpad.net/bugs/1121096
committer: RJ Ryan <email address hidden>
branch nick: 1.11
timestamp: Tue 2013-04-16 23:48:32 -0400
message:
  Add jus's patch to add PreviewDeck to keyboard shortcuts. Fixes Bug #1121096

The toggle-selected control works by faking a Return press on the sidebar widget.

I don't have an explanation for why select-next/prev would stop working after that, but I can confirm that after removing the keyboard shortcut toggle-selected starts working again.

[mixxxbot]

Commented by: rryan
Date: 2014-03-25T17:15:20Z

---

A workaround is to fake a Left or Right press to to close/open, since we don't have shortcuts for those :P.

But LibraryControl should probably just not fake keyboard presses.

[mixxxbot]

Commented by: rryan
Date: 2014-03-25T17:28:40Z

---

Fix committed -- do not fake a Return to toggle a keyboard shortcut.

If Up/Down are ever assigned to a keyboard shortcut then next/prev sidebar item will break.

38684da

[mixxxbot]

Issue closed with status Fix Released.