changes in the skin are not communicated to the menubar options

[mixxxbot]

Reported by: kain88-de
Date: 2013-06-18T08:22:26Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1192074
Tags: polish, skin

---

To reproduce

1. activate samplers in the skin
2. check that the 'View'->show Samplers still thinks they are hidden

You'll also need to hit CTRL+1 two times to make them dissapear again

[mixxxbot]

Commented by: rafvdm
Date: 2014-11-13T19:37:43Z

---

Judging the date, this is about version 1.11.0

It's not only so for the Samplers, it's also for the Vinyl option.

I notice the same problem, somewhat different in version 1.12.0.
I have set up a new bug report for 1.12.0 (https://bugs.launchpad.net/mixxx/+bug/1392454), refering to this one.

[mixxxbot]

Commented by: jercaianu
Date: 2015-03-10T00:00:43Z

---

I would like to be assigned to this bug as my first patch.

[mixxxbot]

Commented by: esbrandt
Date: 2015-03-10T06:26:32Z

---

To assign a bug to yourself, click on the Unassigned link at the top.
The Assign dialog opens, there click on on the Assign Me link.

The bug is now assigned for you to work on it.
If there are any questions let us know, also see http://mixxx.org/wiki/doku.php/bugfix_workflow

Looking forward to your first contribution.

[mixxxbot]

Commented by: kain88-de
Date: 2015-03-10T07:34:31Z

---

You can assign yourself in the ui. Just click the word Unassigned

On 03/10/2015 01:00 AM, alex wrote:

I would like to be assigned to this bug as my first patch.

[mixxxbot]

Commented by: jercaianu
Date: 2015-03-11T19:45:05Z

---

I have looked into this issue and the problem seems to occur because the "SAMPLER" button from the skin xml must be somehow tied to "m_pViewShowSamplers" or "slotViewShotSamplers" in MixxxMainWindow. The same thing happens for the other widgets. I am not sure how i should approach this, since i think that it may imply to either change the skin parser, or the MixxxMainWindow class. Any hints?

[mixxxbot]

Commented by: daschuer
Date: 2015-03-13T19:50:08Z

---

The "SAMPLER" button just changes the value of a ControlObject. This is a global double value, that can be accessed form everywhere by a Key/Item string pair.
In your case I think it is required that you hock on the value change event of the ControlObject.

This can be done by instantiating a ControlObjectSlave and register a callback function (slot).
Please make sure that you instantiate the Cos only fafter the skin has introduced the show sampler CO.
Be aware that instantiating the COS only works for skins that have instantiated the show sampler CO.

By the way: Is your build environment fully on duty? Do you have a IDE with a powerful indexer and are you able to single step though the code? My favorite IDE is Eclipse http://www.mixxx.org/wiki/doku.php/eclipse
This link is also helful: http://www.mixxx.org/wiki/doku.php/bugfix_workflow

[mixxxbot]

Commented by: jercaianu
Date: 2015-03-14T12:25:27Z

---

Thank you for your response! I submitted a pull request in which I solved the problem for the SAMPLER button and i want to see if I should work in the same manner for the other buttons. This solution uses a workaround in which I need to disconnect m_pViewShowSamplers from slotViewShowSamplers because checking the QAction while it is connected to the function that toggles the ControlObject, would trigger infinite recursion. For the moment I can't find an alternative solution. Any ideas?

Link to the pull request: #521

[mixxxbot]

Commented by: daschuer
Date: 2015-03-14T20:17:37Z

---

Disconnect and connect are not fast functions.
You may consider to use a boolean flag to detect the recursion.

[mixxxbot]

Commented by: badescunicu
Date: 2015-04-04T10:02:01Z

---

Fix commited: #526

[mixxxbot]

Commented by: rafvdm
Date: 2015-07-08T17:35:01Z

---

Looks OK for those that I have checked.

Thank you.

[mixxxbot]

Issue closed with status Fix Released.