Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing playlists save dialog (filetype combobox doesn't set type) #7090

Closed
mixxxbot opened this issue Aug 22, 2022 · 12 comments
Closed

Confusing playlists save dialog (filetype combobox doesn't set type) #7090

mixxxbot opened this issue Aug 22, 2022 · 12 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: xorik
Date: 2013-07-03T09:20:03Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1197302
Tags: crate, playlist


Steps:

  1. Select any playlist/crate
  2. Click "Export playlist"
  3. Select any file type, e.g. "Text CSV"
  4. Save file

Expected result: CSV file
Actual result: M3U file

Same thing with others filetypes in combobox.

Gentoo x86_64, mixxx from trunk

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-07-03T09:43:59Z


Is it a bug or a feature? ;-)  Ok, you have reported it, so it is a bug. 

The combo box is part of the system file dialog. And it sets only a filter for the files in the view.
The type of play-list is selected by the file extension only.

To fix this issue, we have to write our own file save dialog, that may will feel foreign on some systems, or we can pop up a type selection box before showing the native file dialog.

@mixxxbot
Copy link
Collaborator Author

Commented by: xorik
Date: 2013-07-03T10:13:58Z


I'm try to write to export into traktor's NML playlist, and was totified: the combobox isn't working :)
Usualy in other software this combobox selects file type to export (e.g. OpenOffice or Audacity).

I think Qt must have something, to handle this combobox?

@mixxxbot
Copy link
Collaborator Author

Commented by: xorik
Date: 2013-07-03T10:18:04Z


*notified

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2013-07-03T10:56:54Z


I would be glad if you could find a smart fix.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-12-15T22:56:35Z


Dennis has a useful comment in Bug #⁠1402841.

I agree that it's expected behavior that if you select a specific type from the drop-down then type a filename with no extension then we should append the one you selected to it.

"""
Under Ubuntu 14.04 Playlist Export function only exports m3u files.

This failure is due to QFileDialog::getSaveFileName only returns filename without extension under Linux.

This bug has been reported here: https://bugreports.qt-project.org/browse/QTBUG-27186

You can hack around this issue by defining a QString selfilter = tr("M3U Playlist (.m3u)") which returns the appropiate filter (like Readable Text (.txt)) after dialog is closed.

Afterwards extract the extension out of the string and append it to QString file_location in baseplaylistfeature.cpp in line 393.
Ugly hack tho :\
"""

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-16T06:59:22Z


#430

@mixxxbot
Copy link
Collaborator Author

Commented by: midzer
Date: 2014-12-30T00:56:19Z


Can be set to "Fix commited" as PR is merged to master

@mixxxbot
Copy link
Collaborator Author

Commented by: lxndr71
Date: 2020-07-28T17:32:43Z


I have the same problem again with build 2.3 r7506 on Linux Mint 19.1

No matter what I choose, it only exports to m3u

@mixxxbot
Copy link
Collaborator Author

Commented by: lxndr71
Date: 2020-07-28T17:37:41Z


I have to explicitly name the file .txt or .pls in the Filename field and set the filetype accordingly, else I only get m3u

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-07-28T22:31:26Z


Since this one is already released.
Can you file a new bug?
This way we can track the issue without messing around with the 2.0 changes.

@mixxxbot
Copy link
Collaborator Author

Commented by: lxndr71
Date: 2020-07-29T06:01:54Z


o.k.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant