Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded 44100Hz in enginefilterblock.cpp #7129

Closed
mixxxbot opened this issue Aug 22, 2022 · 2 comments
Closed

Hardcoded 44100Hz in enginefilterblock.cpp #7129

mixxxbot opened this issue Aug 22, 2022 · 2 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: xorik
Date: 2013-08-06T11:43:06Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1208816


File enginefilterblock.cpp has hardoded sample rating values, which incorrect when sampling rate isn't 44100 Hz.

low = new EngineFilterButterworth8(FILTER_LOWPASS, 44100, (int)s_loEqFreq->get());
band = new EngineFilterButterworth8(FILTER_BANDPASS, 44100, (int)s_loEqFreq->get(), (int)s_hiEqFreq->get());
high = new EngineFilterButterworth8(FILTER_HIGHPASS, 44100, (int)s_hiEqFreq->get()); 

I've made simple test:

  1. change filter's frequency to 800-1000Hz http://s21.postimg.org/fy51lk4s7/2013_08_06_131146_689x272_scrot.png
  2. kill high and low frequency http://s21.postimg.org/wxe00tfzn/2013_08_06_131156_91x133_scrot.png
  3. record some song on different sampling rates and watch spectre: http://s21.postimg.org/8v28325o7/2013_08_06_131254_513x550_scrot.png

You can see wrong result in the 48kHz and 96kHz (higher frequency, than 800-1000), so this need to be fixed.

@mixxxbot
Copy link
Collaborator Author

Commented by: xorik
Date: 2014-01-03T13:25:30Z


rryan, please fix same bug on filtereffect.cpp :)

https://github.com/mixxxdj/mixxx/blob/master/src/engine/enginefiltereffect.cpp#L16

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant