Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't waste CPU time on the master or headphone output if no device is enabled for master or headphone. #7259

Closed
mixxxbot opened this issue Aug 22, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: rryan
Date: 2014-01-14T20:31:50Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1269139
Tags: performance


If no master or headphone device is selected, we should just not calculate the master or headphone output.

(Depends on being able to detect when the sidechain is active).

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-01-14T20:32:23Z


We should also provide COs that represent when a master or headphone output is active so we could hide or disable the relevant parts of the mixer section.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-03-07T18:09:05Z


I will try to fix this along with Bug #⁠1203249.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-04-19T12:24:34Z


It is hard to find out from the hardware preferences if master and/or headphone is required, because recording feature and headphone mix.
I will add dedicated preference option, to disable master mix.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-04-21T13:26:12Z


#239

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-04-21T21:48:13Z


Committed to 687757a

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-10-18T23:08:22Z


I guess I would prefer to revert this unless there's a compelling usecase or performance implication. It's confusing and there are lots of situations where a master mix is required even if there's no master output

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant