Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cent value is only changing if key is changing #7417

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

cent value is only changing if key is changing #7417

mixxxbot opened this issue Aug 22, 2022 · 6 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2014-04-11T07:10:00Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1306408
Tags: easy, polish


  • Load a track,
  • Key and Cent value is displayed
  • Eject track
  • Key value disappears, cent value is still displayed
@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-04-16T01:59:03Z


I think I fixed this because we only set the cent on the widget if the key is not INVALID now.

@mixxxbot
Copy link
Collaborator Author

Commented by: badescunicu
Date: 2014-04-16T16:39:07Z


I have tested Ryan's commits. Indeed, the cents are no longer displayed when there isn't a track loaded.
But we have another problem, the cents value is updating only when the key is changing, which is invalidating the reason for having such a display.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2018-03-23T09:56:06Z


@daschuer
Is this bug still valid?

in 2.1 beta, it appears to me the cent display updates correctly with all skins

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-04-02T23:25:19Z


It looks like we have no skin that features a numeric cent display.
Only Shade has a cent slider, which works.

@mixxxbot
Copy link
Collaborator Author

Commented by: beenisss
Date: 2019-02-25T20:39:45Z


Can this be closed/considered fixed?

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant