Crazy high framerates

[mixxxbot]

Reported by: kain88-de
Date: 2014-08-11T12:42:53Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1355159
Tags: easy, polish, waveform
Attachments: [awesome framerate.png](https://bugs.launchpad.net/bugs/1355159/+attachment/4174451/+files/awesome framerate.png)

---

There seems to be a problem calculating the current framerate. I get values near absolute zero or crazy large values. I attached a screenshot.

[mixxxbot]

Commented by: kain88-de
Date: 2014-08-11T12:42:53Z
Attachments: [awesome framerate.png](https://bugs.launchpad.net/mixxx/+bug/1355159/+attachment/4174451/+files/awesome framerate.png)

[mixxxbot]

Commented by: daschuer
Date: 2014-08-11T15:48:38Z

---

e863 is the real time error counter.
But you are right, it is misleading and should be changed.

[mixxxbot]

Commented by: kain88-de
Date: 2014-08-11T21:17:46Z

---

Ah now I remember something about it. YES we need to change that at
least rename it to error. This is exactly scientific notation there and
my brain is by now hardwired to read it like that.

On Mon, 2014-08-11 at 15:48 +0000, Daniel Schürmann wrote:

e863 is the real time error counter.
But you are right, it is misleading and should be changed.

[mixxxbot]

Commented by: kain88-de
Date: 2014-09-14T15:42:15Z

---

That does the realTimeError Counter actually count? The number of missed frames?

[mixxxbot]

Commented by: midzer
Date: 2014-09-15T21:13:58Z

---

I think the real time error counter has only marginal purpose for the user.
Either discard it completely or move it to a new Label right below "Average frame rate" (without scientific notification)

[mixxxbot]

Commented by: esbrandt
Date: 2014-09-15T21:23:17Z

---

+1
and display it only when running with --developer option, like we do for the VSyncTest waveform summary option

[mixxxbot]

Commented by: rryan
Date: 2014-09-15T21:27:16Z

---

It counts vsync misses. It's useful for developers and useful to ask users
what theirs looks like if we are trying to figure out why their graphics
performance sucks. I'm for leaving it in but labeling it something more
friendly like "Hiccups" or "Glitches".

On Mon, Sep 15, 2014 at 5:13 PM, Dennis Rohner wrote:

I think the real time error counter has only marginal purpose for the user.
Either discard it completely or move it to a new Label right below
"Average frame rate" (without scientific notification)

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1355159

Title:
Crazy high framerates

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1355159/+subscriptions

[mixxxbot]

Commented by: kain88-de
Date: 2014-09-16T08:49:32Z

---

What are we doing when we miss a vsync? Do we just drop the frame or paint it anyway?

Currently I would go with being accurate and renaming it to 'vsync misses'. It's also easy to understand and a better description then "Hiccups" or "Glitches"

[mixxxbot]

Commented by: daschuer
Date: 2014-09-16T11:21:11Z

---

The delayed frame is painted in the next frame (now current) . The frame for the current frame is dropped.
See:
https://github.com/mixxxdj/mixxx/blob/master/src/waveform/vsyncthread.cpp#L110

[mixxxbot]

Commented by: kain88-de
Date: 2014-09-16T17:09:07Z

---

Good then i suggest we rename it to "dropped frames".

On September 16, 2014 1:21:11 PM CEST, "Daniel Schürmann" wrote:

The delayed frame is painted in the next frame (now current) . The
frame for the current frame is dropped.
See:
https://github.com/mixxxdj/mixxx/blob/master/src/waveform/vsyncthread.cpp#L110

--
You received this bug notification because you are subscribed to the
bug
report.
https://bugs.launchpad.net/bugs/1355159

Title:
Crazy high framerates

Status in Mixxx:
Confirmed

Bug description:
There seems to be a problem calculating the current framerate. I get
values near absolute zero or crazy large values. I attached a
screenshot.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1355159/+subscriptions

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[mixxxbot]

Commented by: kain88-de
Date: 2014-09-17T21:32:26Z

---

PR #344

[mixxxbot]

Issue closed with status Fix Released.