Mixxx is leaking memory

[mixxxbot]

Reported by: illuusio
Date: 2014-09-13T07:08:22Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp1369051
Tags: leak
Attachments: [Leakage report from valgrind](https://bugs.launchpad.net/bugs/1369051/+attachment/4202897/+files/Leakage report from valgrind), [Just started Mixx with options LD_PRELOAD="/usr/lib64/libtcmalloc.so.4.2.1" HEAPCHECK=normal ./mixxx](https://bugs.launchpad.net/bugs/1369051/+attachment/4206221/+files/Just started Mixx with options LD_PRELOAD="/usr/lib64/libtcmalloc.so.4.2.1" HEAPCHECK=normal ./mixxx), [After a while AutoDJ have changed songs..](https://bugs.launchpad.net/bugs/1369051/+attachment/4206222/+files/After a while AutoDJ have changed songs..), [Played autodj a while with LeakTrace on](https://bugs.launchpad.net/bugs/1369051/+attachment/4206242/+files/Played autodj a while with LeakTrace on)

---

Mixxx is leaking heavily in memory. See:
http://pastebin.com/yMPvpz8R

[mixxxbot]

Commented by: illuusio
Date: 2014-09-13T07:08:22Z
Attachments: [Leakage report from valgrind](https://bugs.launchpad.net/mixxx/+bug/1369051/+attachment/4202897/+files/Leakage report from valgrind)

[mixxxbot]

Commented by: daschuer
Date: 2014-09-13T08:15:41Z

---

Bug #⁠1335823 might be related

[mixxxbot]

Commented by: illuusio
Date: 2014-09-14T16:17:17Z

---

Yes bug #⁠1335823 probably is related. I spotted at least one Reverb related bad_alloc/free issue. Currently I have pushed memory leaks from 22 MB to 2 MB. Easy ones are done and now I've got to check why Rubberband and Vamp leaks also. Is it our fault or library issue. Rest of the leaks are under 1k so they are trivial but i'll try to crush all that I can.

Curren git is located https://github.com/illuusio/mixxx/tree/leak-fix

[mixxxbot]

Commented by: daschuer
Date: 2014-09-14T18:24:58Z

---

Thank you very much!

Would you mind to do a pull request with the current state?
You fixes are looking self containing.

[mixxxbot]

Commented by: illuusio
Date: 2014-09-17T11:40:06Z
Attachments: [Just started Mixx with options LD_PRELOAD="/usr/lib64/libtcmalloc.so.4.2.1" HEAPCHECK=normal ./mixxx](https://bugs.launchpad.net/mixxx/+bug/1369051/+attachment/4206221/+files/Just started Mixx with options LD_PRELOAD="/usr/lib64/libtcmalloc.so.4.2.1" HEAPCHECK=normal ./mixxx)

[mixxxbot]

Commented by: illuusio
Date: 2014-09-17T11:40:53Z
Attachments: [After a while AutoDJ have changed songs..](https://bugs.launchpad.net/mixxx/+bug/1369051/+attachment/4206222/+files/After a while AutoDJ have changed songs..)

[mixxxbot]

Commented by: illuusio
Date: 2014-09-17T12:23:41Z
Attachments: [Played autodj a while with LeakTrace on](https://bugs.launchpad.net/mixxx/+bug/1369051/+attachment/4206242/+files/Played autodj a while with LeakTrace on)

[mixxxbot]

Commented by: rryan
Date: 2014-11-16T04:03:32Z

---

Can we mark this fixed?

[mixxxbot]

Commented by: illuusio
Date: 2014-11-16T08:58:38Z

---

More or less.. I think so.. Leaks are there but they don't get on the way so just close it..

[mixxxbot]

Commented by: daschuer
Date: 2014-11-16T10:54:51Z

---

I would like to keep it open as a kind of meta bug since it is not completely solved.

[mixxxbot]

Commented by: rryan
Date: 2014-11-20T21:00:41Z

---

IMO that sort of bug is not very useful.

It will occupy a row on our milestone page that is never fixed -- so I'm removing it from 1.12.0.

This is on the same level as "Mixxx shouldn't dereference NULL pointers" or "Mixxx should have high test coverage" -- there isn't a clear metric for the impact or scope of the bug.

[mixxxbot]

Commented by: daschuer
Date: 2017-11-18T14:43:32Z

---

We had no reports lately about leaking memory, so we can close this.

[mixxxbot]

Issue closed with status Fix Released.