Cover Art not displayed in library when importing tracks by dnd until reload

[mixxxbot]

Reported by: esbrandt
Date: 2014-11-18T11:53:15Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1393749
Tags: polish

---

Latest master OSX 10.9.3

Steps to reproduce:
Drag tracks from external file mangers or from within you iTunes Library to the Mixxx library

Expected result:
Tracks get imported to the Mixxxx library, and the Cover Art column fills with the artwork of the imported tracks

Actual result:
Tracks get imported to the Mixxxx library, but the Cover Art column stays blank,.
You have to select the tracks and do "Cover Art-> Reload from track/folder"

[mixxxbot]

Commented by: esbrandt
Date: 2014-11-18T15:10:03Z

---

I think there is now also an issue with displaying the default_cover.png

If you import a track with no cover, the default cover art is displayed on track load in the decks/ library coverart widget, but not underneath the Spinny (Latenight) and not in the cover art column. Reload from track/folder does nothing in this case.

Debug [Main]: WCoverArt::slotCoverFound WCoverArt(0x7fd801302b50)  "CoverInfo(NONE,GUESSED,,0,/path_to.mp3)" QSize(0, 0) 

widget.

[mixxxbot]

Commented by: ywwg
Date: 2014-11-18T15:21:06Z

---

I was actually thinking it's ok not to show the default cover in the spinny or the column. In the case of the spinny, if we show the default it means the default cover becomes a permanent background to the spinny, which the skin designer might not like. But I would be ok with the spinny having the default cover. In the case of the column, I can quickly see which tracks don't have covers, whereas if they had the default cover it will be much harder to figure out what tracks I need to find covers for (that little slice will look like a lot of real cover art slices).

[mixxxbot]

Commented by: rryan
Date: 2014-11-18T15:23:44Z

---

Yea, maybe it's worth one-off reloading the cover data for tracks that get imported to the library while running Mixxx.

[mixxxbot]

Commented by: esbrandt
Date: 2014-11-18T15:44:58Z

---

<quote>In the case of the column, I can quickly see which tracks don't have covers, whereas if they had the default cover it will be much harder to figure out what tracks I need to find covers for (that little slice will look like a lot of real cover art slices).</quote>

I haven't thought about that. Good point. Makes my request from #⁠2 invalid.

OP still valid.

[mixxxbot]

Commented by: kain88-de
Date: 2014-12-04T20:41:07Z

---

We could do a search for tracks in when the coverartcache hits a track with an UNKOWN source.

I'm not sure how we should handle the writes to our database. The easiest is to make one write per track that we discover with an UNKOWN source. If someone drops a ton of tracks then we will also have a lot of writes to the database. We could also decide that we don't care about that and just do it anyway assuming nobody will drop a large amount of external tracks.

[mixxxbot]

Commented by: rryan
Date: 2014-12-10T05:29:00Z

---

Fix for iTunes, Browse, external libraries and dragging a file from the file browser to a deck.
58722db

Drag and drop from the track-table to the sidebar or from a file browser to the sidebar or track table is slightly harder (the fix comes with a performance penalty in the main thread). I think since we already do the bulk add of the tracks (including parsing their metadata) on the main thread in TrackDAO::addTracks, the cost is not that high to make it take longer but I still feel iffy about it.