Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Nextcontrol> in <WidgetStack> behaves strange when used with skin templates #7664

Closed
mixxxbot opened this issue Aug 22, 2022 · 4 comments
Closed

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2014-11-19T20:51:45Z
Status: Invalid
Importance: Low
Launchpad Issue: lp1394354
Tags: skin
Attachments: widget_stack_test.patch


Give up trying, might be a bug.

I want to use a Widgetstack (http://mixxx.org/wiki/doku.php/creating_skins#widgetstack).
and connected a <Pusbutton> to the <WidgetStack> <Nextcontrol> to flip to the next page of the stack.

It all works as expect, AS LONG as the <Pushbutton> connected to the <Nextcontrol> is within the same xml.

I tried to call the <Nextcontrol> , that is within a <Template>, from another xml file.
While calling the different pages of the stack directly works, the <Nextcontrol> wont work.

Interestingly, if you add another empty <Widgetstack> with just the triggers from the other <Widgetstack> in the xml file that has your <Pushbutton> , it works.

Looks complicated, but is easily reproducible with Deere @ current master.
Add a pushbutton to the "tool_bar.xml" and try to hide "deck_visual_row.xml" & "deck_controls_row.xml" by adding an widgetstack for the alternative view mode to "deck_left.xml".

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-11-23T06:15:29Z
Attachments: widget_stack_test.patch


Hm, seems to be working fine for me -- I tried the attached patch.

Result: hitting next replaces the text row (which displays by default) with the controls row. Next again jumps back to the text row.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-11-30T21:13:36Z


Any repro tips?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-07T20:07:16Z


There was probably a misunderstanding on my side how <Nextcontrol> work.
Mixed it up with the trigger attribute. Thanks for looking at it.
Closing.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Invalid.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants