Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using loop_move_X_forward with an active loop can freeze a deck #7683

Closed
mixxxbot opened this issue Aug 22, 2022 · 3 comments
Closed

Using loop_move_X_forward with an active loop can freeze a deck #7683

mixxxbot opened this issue Aug 22, 2022 · 3 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2014-11-26T11:32:27Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1396560
Tags: looping


latest master, OSX 10.9.3

  • Load a track to deck
  • Set a loop, e.g. 4 bars
  • Use the loop_move_X_forward control (e.g loop_move_8_forward) repeatedly to move the loop beyond the tracks end.

Expected result:

  • Not freezing
  • Allow loop_move_X_backward control move loop back into the track

Actual result:

  • Sometimes, the whole app freezes. Have not found the pattern yet.

  • loop_move_X_backward control without function

    Log:
    Warning [Main]: SHOULDN'T HAPPEN: seekInsideAdjustedLoop couldn't find a new position -- seeking to in point

Related?
lp:1342888

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-11-26T14:25:25Z


probably we just shouldn't allow a move to outside the bounds of the track. Likely there's a check to see if the various points are inside the track, and it's failing and getting into a bad state.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-12-26T18:38:33Z


Fixed in 51e7a40

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant