Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached tracks are not saved #7693

Closed
mixxxbot opened this issue Aug 22, 2022 · 7 comments
Closed

cached tracks are not saved #7693

mixxxbot opened this issue Aug 22, 2022 · 7 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2014-11-29T01:04:53Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1397475


This is a regression since
#331

With this patch, cached tracks are not saved, but leaked when shutting down Mixxx, because the destructor are called in a row with shutting down the QT loop. So deleteLater() does not work.

I have tried tonight to fix it with some tricks but I have failed.

I think we must make use of QCoreApplication::aboutToQuit()
http://stackoverflow.com/questions/8165487/how-to-do-cleaning-up-on-exit-in-qt

This sound like a non trivial refactoring job :-/

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-11-30T02:15:11Z


My fix for Bug #⁠1392557 (not yet submitted) gets rid of deleteLater so this should hopefully fix this one as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-11-30T10:25:03Z


Sounds good, thank you.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-12-02T03:30:28Z


probably fixed now?

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-12-06T20:10:06Z


not fixed

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-12-21T17:47:46Z


e2ec73d

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-12-21T17:48:08Z


Should be fixed with this new approach to track caching.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant