No default skin in 1.12 if the configured one is missing

[mixxxbot]

Reported by: jclaveau
Date: 2014-12-01T13:27:50Z
Status: Expired
Importance: Critical
Launchpad Issue: lp1397989

---

If the configured skin doesn't exist in the skin folder Mixxx will stop :

*** Error in `/home/jean/dev/mixxx/mixxx_demos/mixxx': free(): invalid pointer: 0x00007ffff72075c0 ***

Program received signal SIGABRT, Aborted.
[Switching to Thread 0x7fff60f28700 (LWP 13161)]
0x00007ffff17cdbb9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56	../nptl/sysdeps/unix/sysv/linux/raise.c: Aucun fichier ou dossier de ce type.
(gdb) backtrace 
#0  0x00007ffff17cdbb9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
mixxxdj/mixxx#4910  0x00007ffff17d0fc8 in __GI_abort () at abort.c:89
mixxxdj/mixxx#4911  0x00007ffff180ae14 in __libc_message (do_abort=do_abort@entry=1, 
    fmt=fmt@entry=0x7ffff1919668 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
mixxxdj/mixxx#4912  0x00007ffff18170ee in malloc_printerr (ptr=<optimized out>, str=0x7ffff1915759 "free(): invalid pointer", action=1)
    at malloc.c:4996
mixxxdj/mixxx#4913  _int_free (av=<optimized out>, p=<optimized out>, have_lock=0) at malloc.c:3840
mixxxdj/mixxx#4914  0x00007ffff6fdcbb1 in qAtomicAssign<QSqlDatabasePrivate> (x=0x7fff50009920, 
    d=@0x15d90a88: 0x7ffff72075c0 <QSqlDatabasePrivate::shared_null()::n>)
    at ../../include/QtCore/../../src/corelib/thread/qatomic.h:201
mixxxdj/mixxx#4915  QSqlDatabase::operator= (this=this@entry=0x15d90a88, other=...) at kernel/qsqldatabase.cpp:714
mixxxdj/mixxx#4916  0x0000000000947aa1 in LibraryScanner::run (this=0x15d90a70) at src/library/libraryscanner.cpp:141
mixxxdj/mixxx#4917  0x00007ffff540032f in QThreadPrivate::start (arg=0x15d90a70) at thread/qthread_unix.cpp:349
mixxxdj/mixxx#4918  0x00007ffff31e6182 in start_thread (arg=0x7fff60f28700) at pthread_create.c:312
mixxxdj/mixxx#4919 0x00007ffff1891fbd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

[mixxxbot]

Commented by: rryan
Date: 2014-12-01T15:22:12Z

---

This one is a beta blocker since it likely affects Mixxx 1.11.

We need to verify that a Mixxx 1.11 -> 1.12 beta -> 1.11 doesn't leave the user unable to start Mixxx 1.11 because we write a skin to the config that isn't available in Mixxx 1.11.

Also, we should fix this in Mixxx 1.12 in a nice way. What if we had a screenshot.png that every skin could provide and had a nice skin picker that showed the screenshots in a carousel?

[mixxxbot]

Commented by: ywwg
Date: 2015-01-11T20:01:04Z

---

Can't reproduce.

• If I remove the skin definitions from the config, it falls back to LateNight
• If I create a bogus skin definition in the config, it falls back to LateNight
• If I make the skin definition blank, it falls back to LateNight
• If I was using a Deere skin in 1.11, 1.12 loads the new Deere (thanks to my recent patch)

I can't get mixxx to crash at all -- please retest on latest trunk, and if it does crash, please upload a copy of your config and a list of the contents of the res/ directory. Maybe this is an issue with a half-removed skin?

[mixxxbot]

Commented by: ywwg
Date: 2015-01-11T20:03:14Z

---

(Looking at the backtrace, it looks like the crash occurred during library scanning, not skin loading)

[mixxxbot]

Commented by: ferranpujolcamins
Date: 2016-04-10T17:23:55Z

---

Can't reproduce this with the latest master.

[mixxxbot]

Commented by: ywwg
Date: 2016-04-11T13:31:40Z

---

does it exist in 2.0.0?

[mixxxbot]

Commented by: janitor
Date: 2016-06-11T04:17:18Z

---

[Expired for Mixxx because there has been no activity for 60 days.]

[mixxxbot]

Issue closed with status Expired.