Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform disappeas playaing on win XP + WDM-KS #7757

Closed
mixxxbot opened this issue Aug 22, 2022 · 11 comments
Closed

Waveform disappeas playaing on win XP + WDM-KS #7757

mixxxbot opened this issue Aug 22, 2022 · 11 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2014-12-22T07:05:15Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1404803
Tags: waveform
Attachments: cast.mp4


When a track is playing the waveform disappears and only the lead-In is shown, once it stops. the view is as expected.
This happens with Sound-API: WDM-KS
The problem is gone when playing with direct sound.

I think there is something wrong with the reported latencies.
Around line:

VisualPlayPosition::setTimeInfo(timeInfo);

Can someone on a windows environment check that?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-22T13:57:40Z


Can confirm with OSX 10.9.
But i think the reason is within your pitch scale patch #415
The issue is only with the patch applied, if the patch gets reversed, everything back to normal.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-22T14:39:51Z


I can reproduce it reliable with a plain mixxx-master-git5001-x86.exe from build server.
So in my case, it can't be related with pitch scale patch.
WDM-KS -> lead in with triangles
Direct sound -> waveforms
Stop = waveform in both cases.

@jus: Has you issue the same symptoms? Do you have to do something special to get in this state?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-22T15:07:26Z


It was like this:
OSX Core-Audio-> lead in with triangles
Stop = waveform

Doo.
I just rebuild with your patch applied and could NOT reproduce it.
So my assumption about the patch was not correct. Switched waveforms and skins to no avail, still works as expected. Will keep an eye on it.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-22T21:04:08Z
Attachments: cast.mp4


Just happened again, did not found a definitive pattern yet, see short screen recording.
For once i was able to toggle waveform/preroll display by (de)selecting a microphone input in the sound hardware preferences. Did not catch that on video though.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-12-22T21:39:33Z


  • Does this happen with waveforms other than RGB?
  • Can you hear the audio?
  • Can you print out the visual_playposition control object and see what it's doing?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-22T22:29:05Z


Thank you for help, on win xp it look similar.
I think we need to add a plausibility check on timeInfo at

VisualPlayPosition::setTimeInfo(timeInfo);

A faulty value of timeInfo will be helpfull here. Are you able to break at the line above?
If not, no problem, we should be able to fix it without.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-22T22:30:04Z


It happens with all waveforms
I can hear Audio
can't print visual_playposition because I have no development environment.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-23T23:18:14Z


Fixed since 40bd85f
by disabling the waveform syncing.
Not sure if it possible to sync again with the effected sound APIs

It currently locks one sync value per deck in mixxx.log maybe we can find a pattern .. of fix it in portaudio.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-23T23:18:56Z


@jus: please check it with your issue.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2014-12-23T23:51:23Z


oh good, glad you caught this

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant