Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong mp3 track duration and wrong crossfader time #7768

Closed
mixxxbot opened this issue Aug 22, 2022 · 8 comments
Closed

wrong mp3 track duration and wrong crossfader time #7768

mixxxbot opened this issue Aug 22, 2022 · 8 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: schneider-abg
Date: 2014-12-26T18:58:57Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1405832
Tags: soundsource
Attachments: test.mp3


The duration time of some mp3 files is wrong. If such a file is played then the NEXT crossfader time is very short (about 1-2s instead of 10s) if started by "Überblenden" button while in Auto-DJ list.

example of attached file:

shown by mixxx: 18:54
shown by nautilus: 3:08
shown by mp3diags: 3:08

@mixxxbot
Copy link
Collaborator Author

Commented by: schneider-abg
Date: 2014-12-26T18:58:57Z
Attachments: test.mp3

@mixxxbot
Copy link
Collaborator Author

Commented by: schneider-abg
Date: 2014-12-26T19:09:01Z


bug is reproducible with mixxx 1.11.0 at ubuntu 12.04 (64 Bit)

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-01-04T10:00:04Z


The file seems to have same tagging issues:
TagLib: MPEG::XingHeader::parse() -- Xing header doesn't contain the total stream size.

The wrong duration is read from the ID3 tags of the file. Currently the information in the corresponding TrackInfoObject is not updated in SoundSourceProxy::open() as indicated by the comments in the code. I'm not sure if those comments are still valid and why the duration and other audio properties of the TrackInfoObject are not updated.

All these issues are already fixed in the new SoundSource API branch. In SoundSourceProxy::open() all metadata in TrackInfoObject about the audio stream that has been read from the tags of the file is now replaced with the actual values reported by the opened AudioSource.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-01-04T10:01:32Z


Relates to: https://bugs.launchpad.net/mixxx/+bug/1156569

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-01-04T11:02:44Z


But now another problem occurs: After the track has been opened and its audio properties have been adjusted it appears twice in the library.

  1. Copy file and "Rescan Library":
  • Original track: Duration = 18:54, Bitrate = 32
  1. Play the track:
  • Original track: Duration = 18:54, Bitrate = 32
  • Updated track: Duration = 3:08, Bitrate = 191
    WRONG: Track has been duplicated!
  1. Play the original track:
  • Original track: Duration = 18:54, Bitrate = 32
  • Updated track: Duration = 3:08, Bitrate = 191
  1. Analyze the original track:
  • Original track: Duration = 3:08, Bitrate = 191
  • Updated track: Duration = 3:08, Bitrate = 191

This only happens if the file is played immediately in step 2 after adding it to the library. If it is analyzed first in step 2 then we end up with only a single track as expected:

  1. Copy file and "Rescan Library":
  • Duration = 18:54, Bitrate = 32
  1. Analyze the track:
  • Duration = 3:08, Bitrate = 191
    OK

For each file only a single track should appear in the library, i.e. the file path must be unique for each track. Do we need to open another bug for this issue?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-04-15T20:38:54Z


Do we need to open another bug for this issue?

Yes.
It this one solved then?

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-04-16T08:15:39Z


Wrong duration bug fixed by:
https://bugs.launchpad.net/mixxx/+bug/1156569
#411

After the file has been opened (i.e. by analyzing or loading) the duration is displayed correctly.

Testing with a fresh library did not produce a second entry for the same file.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant