Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the usage of the word "pitch" to ensure correct translations #7791

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2015-01-02T17:36:44Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1407126
Tags: easy, i18n, polish


This is how we currently use the word "pitch" in our translatable content:
https://www.transifex.com/projects/p/mixxxdj/viewstrings/#en/github-master/38118835?q=pitch

Pitch has become a meaningless term, we have it all mixed up.

To ensure the quality of the translations, we need unambiguous source strings if possible.

We should define when to use
a) Key
b) Pitch
c) Tempo

and stick to it. The current source strings need a clean-up by a native speaker. Who can help?

Atm the level of participation with regards to translations are pretty good, so i`d like to use that steam and push a cleaned up version of so we can have it translated asap.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-01-02T18:04:24Z


My view on this is like that:

a) Key = de: Tonart
https://en.wikipedia.org/wiki/Key_%28music%29
A track property = Original Key
In case of a pitched track = Current Key
(All tones a pitched by the same amount the mode (Minor/Major) is unchanged
Linear Pitch: this is what a turntable can do change the turning speed, tempo and pitch changes with the same ratio.

b) Pitch = de: Tonhöhe
https://en.wikipedia.org/wiki/Pitch_%28music%29
Pitch = 0 track it at its original key

c) Tempo = de: Tempo
https://en.wikipedia.org/wiki/Tempo
Measured in BPM
Mixx has no dedicated independent Tempo slider, but it can adjusted by the Speed slider independent from pitch when keylock is enabled.

d) Speed = de: Geschwindigkeit
This is what is labeled as "pitch" on turntables. We drop the word in Mixxx for it, because we can change pitch and tempo independent. The Speed slider does not effect pitch if keylock is enabled.

@mixxxbot
Copy link
Collaborator Author

Commented by: ssouravsingh12
Date: 2016-11-23T19:21:04Z


I am interested in working on the issue. How do I start?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2016-11-24T06:47:50Z


Read: http://www.mixxx.org/wiki/doku.php/bugfix_workflow

Find all strings containing pitch, tempo and speed and change the wording according to the definition above if not already happened.

@mixxxbot
Copy link
Collaborator Author

Commented by: mjgupta
Date: 2020-02-24T15:11:52Z


Is this issue is still open, I would like to work on it as a beginner bug.
Also, the transifex link doesn't open. Here is the error link: https://imgur.com/a/uzhmoV8.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-02-24T16:33:21Z


Thank you for caring for that bug.
For me the above transiflex link is working.
Did you create a transiflex acount first?

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant