Wishlist: additional BPM conversions, i.e. 4/3 of detected BPM

[mixxxbot]

Reported by: ronso0
Date: 2015-06-05T12:43:14Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1462350
Tags: bpm, wishlist
Attachments: lp1462350.diff

---

Well, actually self-explaining title.

I'm glad MIXXX detects BPM of most of my new tracks. The build in conversions 2/3, 3/4, Double, Half are handy.
But most of my music is hm.. weird DnB, IDM, noise, experimental stuff, Dubstep, where MIXXX detects the beat, but instead of i.e. 170.5 it displays 127,875 (so correct BPM is 4/3).

I suppose it's quite easy to integrate additional conversions.? This would save the manual calculations and avoid beat-offsets resulting from round-off errors with strange floating point BPMs.

Besides: MIXXX is great!

mixxx-1.12.0-beta1-1.12-git5442-release-trusty-amd64
linux-3.14.23-rt20
Thinkpad Edge 525 - AMD A4-3300M, 8GB

[mixxxbot]

Commented by: esbrandt
Date: 2015-06-05T13:44:36Z

---

Hi,
have you tried to change the BPM range in Preferences>Beat detection?

However, attached patch adds 4/3 BPM option to mouse menu and properties editor.
Please test.

[mixxxbot]

Commented by: esbrandt
Date: 2015-06-05T13:44:53Z
Attachments: lp1462350.diff

[mixxxbot]

Commented by: ronso0
Date: 2015-07-04T14:36:31Z

---

Hi jus,
Thanks for your quick reply!
I finally found time to compile with applied patch:
Tested. It works!
I found some other beat detection mistakes, 7/8 or 3/2. Maybee I'm able to add buttons for those conversion myself.

[mixxxbot]

Commented by: daschuer
Date: 2015-08-07T06:59:21Z

---

Hi Ronny,

did you manage to fix this bug entirely?
It would be nice if you do a GitHub PR or attach your patch against the master branch.

Here some hints:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow
Just ask, if you have additional questions.

Thank you

Daniel

[mixxxbot]

Commented by: ronso0
Date: 2015-08-07T08:37:11Z

---

Hi Daniel,

thanks for reminding me...
jus' patch worked as expected. I frequently need another additional BPM
conversion (3/2) and got stuck at creating a diff/patch, therefore
didn't give any feedback yet. sorry.
I'm not into git, yet, and right now I'm about to leave foor vacation,
so if anyone else could finish this? Thanks.

Again, again & again: you're doing great work with Mixxx!! Keep on!

Regards
Ronny

On 07.08.2015 08:59, Daniel Schürmann wrote:

Hi Ronny,

did you manage to fix this bug entirely?
It would be nice if you do a GitHub PR or attach your patch against the master branch.

Here some hints:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow
Just ask, if you have additional questions.

Thank you

Daniel

** Changed in: mixxx
Status: New => Confirmed

** Changed in: mixxx
Importance: Undecided => Wishlist

** Changed in: mixxx
Milestone: None => 2.1

[mixxxbot]

Commented by: daschuer
Date: 2015-12-30T21:09:45Z

---

Playing with my BeatMap fix:
#812

I notice that it is already hard to correctly use the 2/3 BPM and the 3/4 BPM buttons.
It looks like that we need a bunch of those buttons to entirely solve this issue, sticking to this approach.

It is hard to predict what will happen with the beat position if you press a 7/8 button, also for calculate the resulting bpm the user will likely wish he had a calculator.
It is also already hard to spot that you need to press the 3/4 BPM buttons to go from 124 Bpm to 93.

there might be a chance to make it better. But how.

What are the use-cases?

The main use case is:
A auto detected "not ideal" beatgrid is likely on a lets say 1/8 grid of the desired beet, because it was triggered by an different sound (instrument).
Tapping a beat will more closely at the desired beat, but not exact. so it is not a good solution.

Think we have two cases:

1. Visual beatgrid editing align the beatgrid to one beat and you see that it misses the following beat.
   Here we need may introduce an option to pick the next beat but stick on the 1/8 grid
   2 Tapping the beats. Here we may round to a 1/8 grid

Any thought ... did I miss something?

[mixxxbot]

Commented by: ronso0
Date: 2017-01-03T13:01:22Z

---

whoopsy, more than a year...
I added two conversions (3/2 and 4/3) as patch doesn't match the file locations anymore.
#1106

I agree that more/finer conversions are pointless unless one is so trained at counting BPM to know he needs 7/11 conversion. Counting buttons taps over a much longer period could improve accuracy. And there are interesting suggestions about visual beatgridding in bugs and PRs. So I shut up...

[mixxxbot]

Commented by: daschuer
Date: 2017-01-03T15:13:55Z

---

Thank you for coming back to this.

By the way:
Fix committed means merged to master.

[mixxxbot]

Commented by: daschuer
Date: 2017-01-03T15:17:55Z

---

In order to commit your changes, we need your permission.

Please sign:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

And comment here when done.
Thank you.

[mixxxbot]

Commented by: ronso0
Date: 2017-01-04T16:02:24Z

---

Ah okay, thanks! And "Fix Released" means it's in the next stable/not-nightly release?

Signed the form.

[mixxxbot]

Commented by: daschuer
Date: 2017-01-04T16:47:21Z

---

Yes.

Thank you for your work!

[mixxxbot]

Commented by: daschuer
Date: 2017-01-07T20:03:47Z

---

I like to put your name into the about Box of Mixxx.
Normally we use our real names there. Is it OK for you?

[mixxxbot]

Issue closed with status Fix Released.